Skip to content

Commit

Permalink
content/static,internal/fetch/dochtml: expand all nav elements by def…
Browse files Browse the repository at this point in the history
…ault

We’ve received feedback that a fully-collapsed side nav prevents users
from being able to see package structure at a glance. Expand all
functions and types by default.

Also updates CSS for the side nav to not show a scroll bar if the
content doesn’t overflow.

Updates golang/go#40612
Fixes golang/go#40715

Change-Id: I22049e394b8705316e1ebe1cb9691c6317c61c5b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/248183
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
  • Loading branch information
andybons committed Aug 13, 2020
1 parent f245a6b commit 658a7a4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion content/static/css/sidenav.css
Expand Up @@ -113,7 +113,7 @@
display: block;
max-height: calc(100vh - var(--header-height));
overflow-x: hidden;
overflow-y: scroll;
overflow-y: auto;
padding-top: 1rem;
padding-left: 0.25rem;
position: sticky;
Expand Down
6 changes: 3 additions & 3 deletions internal/fetch/dochtml/template.go
Expand Up @@ -89,7 +89,7 @@ var htmlPackage = template.Must(template.New("package").Funcs(
{{if .Funcs}}
<li class="DocNav-functions" role="none">
<span class="DocNav-groupLabel" role="treeitem" aria-expanded="false" aria-level="1" aria-owns="nav-group-functions" tabindex="-1">Functions</span>
<span class="DocNav-groupLabel" role="treeitem" aria-expanded="true" aria-level="1" aria-owns="nav-group-functions" tabindex="-1">Functions</span>
<ul role="group" id="nav-group-functions">
{{range .Funcs}}
<li role="none">
Expand All @@ -102,15 +102,15 @@ var htmlPackage = template.Must(template.New("package").Funcs(
{{if .Types}}
<li class="DocNav-types" role="none">
<span class="DocNav-groupLabel" role="treeitem" aria-expanded="false" aria-level="1" aria-owns="nav-group-types" tabindex="-1">Types</span>
<span class="DocNav-groupLabel" role="treeitem" aria-expanded="true" aria-level="1" aria-owns="nav-group-types" tabindex="-1">Types</span>
<ul role="group" id="nav-group-types">
{{range .Types}}
{{$tname := .Name}}
<li role="none">
{{if or .Funcs .Methods}}
{{$navgroupname := (printf "nav.group.%s" $tname)}}
{{$navgroupid := (safe_id $navgroupname)}}
<a class="DocNav-groupLabel" href="#{{$tname}}" role="treeitem" aria-expanded="false" aria-level="2" data-aria-owns="{{$navgroupid}}" tabindex="-1">type {{$tname}}</a>
<a class="DocNav-groupLabel" href="#{{$tname}}" role="treeitem" aria-expanded="true" aria-level="2" data-aria-owns="{{$navgroupid}}" tabindex="-1">type {{$tname}}</a>
<ul role="group" id="{{$navgroupid}}">
{{range .Funcs}}
<li role="none">
Expand Down

0 comments on commit 658a7a4

Please sign in to comment.