Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es_Es.ts #1192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update es_Es.ts #1192

wants to merge 1 commit into from

Conversation

Adrlopgal
Copy link

Hi! I'm a Spanish biologist, linguist and writer. GoldenDict is a wonderful program that is helping me a lot in my everyday work. This is my first contribution. I have done a full translation to Spanish of many untranslated words and a complete update of several grammatical errors that there was in the previous version of this file. The other Spanish variants also present grammatical errors that I can correct.

I'd be very glad if you could update the file with my changes.

Thanks in advance.

Hi! I'm a Spanish biologist, linguist and writer. GoldenDict is a wonderful program that is helping me a lot in my everyday work. This is my first contribution. I have done a full translation to Spanish of many untranslated words and a complete update of several grammatical errors that there was in the previous version of this file. The other Spanish variants also present grammatical errors that I can correct.

I'd be very glad if you could update the file with my changes.

Thanks in advance.
@Adrlopgal
Copy link
Author

By the way, the "Select All" option that appears in the context menu (right click on any article page) cannot be translated. That line doesn't appear in the .ts file. Could it be corrected?

Thanks.

@vedgy
Copy link
Member

vedgy commented May 9, 2023

I guess @Abs62 wasn't sure this pull request improves the translation. For example, Google Translate doesn't prefer either the original or the replacement translation in the following cases:

-        <translation>Activado</translation>
+        <translation>Habilitado</translation>
-        <translation>Texto a previsualizar:</translation>
+        <translation>Texto que previsualizar:</translation>

In general, a person who doesn't know a language cannot verify translation changes. But I think we have to assume good intentions of a translator. If something visible breaks, another native speaker can report and fix it (or in the worst case recommend reverting a bungled translation commit).

@Adrlopgal, can you please explain the reasons for the diffs I quoted to a non-Spanish speaker? Just to give me an idea... I see that you have removed your goldendict fork, but the ts file can still be downloaded and the conflicts with the current master branch should be few and straightforward to fix, hopefully.

@vedgy
Copy link
Member

vedgy commented May 12, 2023

005860e made opposite changes to "Activado"=>"Habilitado" proposed by this pull request. For example:

-Si se habilita, puede activarlo y desactivarlo desde la ventana principal
+Una vez activada, se puede activar o desactivar desde la ventana principal

A review of this translation update by a Spanish speaker will be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants