Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't replace previously searched-for text with title #1523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vedgy
Copy link
Member

@vedgy vedgy commented Jun 16, 2022

The current page title is not a likely search term, seeing as it occurs
in many places all over the page. The user is more likely to search for
the phrase that was last searched for.

The current page title is not a likely search term, seeing as it occurs
in many places all over the page. The user is more likely to search for
the phrase that was last searched for.
@wildekat
Copy link

The current page title is not a likely search term

I think the idea is for the user to be able to build on it - adding other words, that is.
At least that's how I use it.

@vedgy
Copy link
Member Author

vedgy commented Jun 17, 2022

I think the idea is for the user to be able to build on it - adding other words, that is.
At least that's how I use it.

Yes, that must be the idea. I don't do that myself as I can type the search term fast enough to not bother editing the pre-filled word. But repeating the previous search is something I have use for. The new behavior would be more similar to web browsers, which keep the last searched-for phrase in the Find-in-page field.

Would you edit the page title more frequently than reuse/edit the previous search term?

@wildekat
Copy link

I don't do that myself as I can type the search term fast enough to not bother editing the pre-filled word.

That's a fair point.

Would you edit the page title more frequently than reuse/edit the previous search term?

It's only occasionally that I use this feature and I could learn to live without it, but on the other hand,
I hardly ever feel the need to reuse a search term from some previous look-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants