Prepare for Qt WebEngine support - part 1 #1552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2cdf9b added `_=0;` at the end of several evaluateJavaScript() scripts. I suppose this dummy statement could have improved performance or even prevented crashes in case the last JavaScript statement returned a large result, e.g. `%1=window.getSelection().getRangeAt(0);`. But the return value of Selection.removeAllRanges() is None (undefined), so `_=0;` is probably not useful here.
Without this call QNetworkReply::isFinished() returns false even after the finished() signal is emitted. Depending on Qt WebKit implementation, the wrong isFinished() return value could cause a bug. For example, code that uses a network reply may call isFinished(); connect to the finished() signal if it returns false; use and deleteLater() the reply immediately otherwise. If the finished() signal has been emitted earlier, the using code would wait for it forever.
Without the QNetworkReply::setUrl() call, the reply's url() remains empty, in which case Qt WebEngine glue code would require a workaround to use the request's url() instead. And the workaround would not even work in the case of BlockedNetworkReply, which does not call QNetworkReply::setRequest().
vedgy
force-pushed
the
webkit-or-webengine-part-1
branch
from
b2ef992
to
b549570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the first 4 commits of #1542. I hope that Qt WebEngine support can be reviewed and merged into master by degrees, starting with this PR.
See the commit messages for details.