Remove hardcoded port #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodePort is able to dynamically grab a port to bind to
DrPsychick
reviewed
Apr 1, 2023
| @@ -18,9 +18,6 @@ spec: | |||
| port: {{ .Values.service.servicePort }} | |||
| targetPort: 3000 | |||
| protocol: TCP | |||
| {{- if eq .Values.service.type "NodePort" }} | |||
There was a problem hiding this comment.
This is backwards breaking and the NodePort should stay configurable.
The port is not hardcoded but set by default, IF service type is "NodePort" (which by default is "ClusterIP").
| @@ -35,9 +35,6 @@ service: | |||
| ## from within the cluster. To expose externally, consider a "NodePort" or "LoadBalancer" service. | |||
| type: ClusterIP | |||
| ## Further configuration if service is of type "NodePort" | |||
| nodePort: | |||
There was a problem hiding this comment.
This must stay, but may be commented out as it is only used when type: NodePort
|
@dsloanather do you still want this contribution to be considered? Do you want to make the suggested changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodePort is able to dynamically grab a port to bind to