New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a better error message for download mode #1492
base: main
Are you sure you want to change the base?
Commits on Dec 12, 2019
-
Adding a better error message for download mode
When it's missing, we write a short message saying so, and when it's invalid, we do approximately the same thing. Athens has a lot of configuration options, so it's naturally easy to get them wrong or forget something. Nicer error messages should help. If this code is acceptable, I'd like to apply it to a few other config values (in a follow-up PR) that are easy to get wrong. ref gomods#1491, since this checks existence and validates values for download mode, and also reports errors in a more human-friendly way cc/ @bluekeyes
Configuration menu - View commit details
-
Copy full SHA for 0224e53 - Browse repository at this point
Copy the full SHA 0224e53View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa2631c - Browse repository at this point
Copy the full SHA fa2631cView commit details
Commits on Dec 13, 2019
-
Making some progress toward removing the specific config error
cc/ @marwan-at-work, I think I've addressed almost all of your comments here, but let me know if this overall design is what you had in mind. Tests are still failing, I'm fixing those shortly
Configuration menu - View commit details
-
Copy full SHA for 834eba4 - Browse repository at this point
Copy the full SHA 834eba4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f45a03b - Browse repository at this point
Copy the full SHA f45a03bView commit details
Commits on Dec 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4715103 - Browse repository at this point
Copy the full SHA 4715103View commit details
Commits on Feb 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e928a0f - Browse repository at this point
Copy the full SHA e928a0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32e7c28 - Browse repository at this point
Copy the full SHA 32e7c28View commit details -
Configuration menu - View commit details
-
Copy full SHA for a846557 - Browse repository at this point
Copy the full SHA a846557View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25b5860 - Browse repository at this point
Copy the full SHA 25b5860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b6d62 - Browse repository at this point
Copy the full SHA 36b6d62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c6b90b - Browse repository at this point
Copy the full SHA 2c6b90bView commit details
Commits on Feb 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5b85142 - Browse repository at this point
Copy the full SHA 5b85142View commit details -
Not passing an op to Validate functions
Also removing the op from DownloadFile.Validate
Configuration menu - View commit details
-
Copy full SHA for 65662f5 - Browse repository at this point
Copy the full SHA 65662f5View commit details -
Not checking for error strings in mode test
Just checking to see if there's an error. Also adding tests for valid modes
Configuration menu - View commit details
-
Copy full SHA for e962a4d - Browse repository at this point
Copy the full SHA e962a4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b29dcf - Browse repository at this point
Copy the full SHA 1b29dcfView commit details -
removing struct tag for config port validation
Looks like validate tags don't have a prefix checker. This seems easier than building a custom validator
Configuration menu - View commit details
-
Copy full SHA for d6a7cbd - Browse repository at this point
Copy the full SHA d6a7cbdView commit details
Commits on Mar 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for de71cb7 - Browse repository at this point
Copy the full SHA de71cb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc70e12 - Browse repository at this point
Copy the full SHA cc70e12View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5eda16 - Browse repository at this point
Copy the full SHA a5eda16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 198d574 - Browse repository at this point
Copy the full SHA 198d574View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee8f4d1 - Browse repository at this point
Copy the full SHA ee8f4d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cc9f84 - Browse repository at this point
Copy the full SHA 2cc9f84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9695c36 - Browse repository at this point
Copy the full SHA 9695c36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 726b77c - Browse repository at this point
Copy the full SHA 726b77cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4320101 - Browse repository at this point
Copy the full SHA 4320101View commit details