Improve layout matcher and simplify GREYElementInteraction #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axi0mX
force-pushed
the
interaction
branch
9 times, most recently
from
278f3c7
to
d397bcb
Compare
|
@axi0mX, there's a feature addition for selecting a specific element when Multiple Matchers are matched that's coming in which touches |
axi0mX
force-pushed
the
interaction
branch
8 times, most recently
from
c1fe31c
to
03a851f
Compare
axi0mX
changed the title
|
PR is ready for review. I removed other commits which modified the rest of GREYElementInteraction so that we could get it reviewed and merged soon. |
axi0mX
force-pushed
the
interaction
branch
3 times, most recently
from
e4d1a82
to
297a859
Compare
|
@axi0mX, you'd need to resolve all the merge conflicts here since the code has been updated for the latest release. |
axi0mX
force-pushed
the
interaction
branch
2 times, most recently
from
de29fc2
to
097c18a
Compare
|
Updated. |
axi0mX
force-pushed
the
interaction
branch
4 times, most recently
from
f424d0f
to
24753ab
Compare
axi0mX
changed the title
axi0mX
force-pushed
the
interaction
branch
2 times, most recently
from
67f6c4a
to
1fbe1d1
Compare
… we don't need it in every GREYAction
axi0mX
force-pushed
the
interaction
branch
4 times, most recently
from
3d0eb62
to
8523e3f
Compare
… inputs into formatted string)
axi0mX
force-pushed
the
interaction
branch
2 times, most recently
from
7472a1e
to
2f7bd17
Compare
…nts:error: and fix possible dereference of a NULL pointer.
…d assert to a helper method
|
Needs some conflict resolution, @axi0mX |
|
@axi0mX what is the commit that's needed from the system alert PR? Are both PR's together? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite: 1 commit from system alert PR.