Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRADLE-2894: fixed bug that does not recognize the default wb resource if manually changed #368

Merged
merged 2 commits into from Mar 3, 2015
Merged

GRADLE-2894: fixed bug that does not recognize the default wb resource if manually changed #368

merged 2 commits into from Mar 3, 2015

Conversation

aaschmid
Copy link
Contributor

I have found this bug on Stackoverflow question "http://stackoverflow.com/questions/22957776/gradle-eclipse-wtp-plugin-adding-wb-resource-removes-webappdir-from-deployment" and the documentation says

      //you can add a wb-resource elements; mandatory keys: 'sourcePath', 'deployPath':
      //if sourcePath points to non-existing folder it will *not* be added.
      resource sourcePath: 'extra/resource', deployPath: 'deployment/resource'

But this does override all the default entries and adds only the manually added ...
IMHO this is same problem as we have had with facets, see http://forums.gradle.org/gradle/topics/additional_eclipse_wtp_facet_overwrites_default_facets, which René changed a few days ago.

@aaschmid aaschmid changed the title fixed bug that does not recognize the default wb resource if manually changed GRADLE-2894: fixed bug that does not recognize the default wb resource if manually changed Dec 14, 2014
@bigdaz
Copy link
Member

bigdaz commented Dec 18, 2014

Hi. Thanks for the PR. I notice that EclipseWtpComponent.property(Map) has the same semantic, even though there are no defaults to override (yet).

For consistency, would you mind changing property as well?

Thanks, Daz

@aaschmid
Copy link
Contributor Author

good idea, done :-)

bigdaz pushed a commit that referenced this pull request Mar 3, 2015
GRADLE-2894: fixed bug that does not recognize the default wb resource if manually changed
@bigdaz bigdaz merged commit 17780a8 into gradle:master Mar 3, 2015
@bigdaz
Copy link
Member

bigdaz commented Mar 3, 2015

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants