Angular deprecation: Dashboards: Add link to auto-migrate compatible panels to dashboard warning

[xnyo]

What is this feature?

Adds a link to Angular dashboard warnings that points to &__feature.autoMigrateOldPanels=true.

It is be displayed only when the dashboard contains panels that can be migrated.

Requires #84034 to be merged before this PR, in order to set the feature flag from URL in production mode.

Why do we need this feature?

Simplify auto-migrating Angular panels.

Who is this feature for?

Grafana users with Angular panel plugins.

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Need to add more tests

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[grafana-delivery-bot]

Hello @xnyo!
Backport pull requests need to be either:

• Pull requests which address bugs,
• Urgent fixes which need product approval, in order to get merged,
• Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

[lukasztyrala]

Hi @xnyo, at DataViz team we are trying to put together a script (guidelines) to use when communicating with customers about the expected deprecations and how to safely test the auto migration. There are few things we need to understand:

1. Do we know how we will integrate the migration button into the UI and where the banner will be displayed?
2. Will there be an option to revert the automigration (or will it still be required to save dashboard explicitly after the auto migration)?

cc @nmarrs @leeoniya

[xnyo]

Hi @lukasztyrala

Do we know how we will integrate the migration button into the UI and where the banner will be displayed?

The link displayed in the screenshot is shown in a warning that's displayed at the top of dashboards that use Angular plugins. This warning is displayed since Grafana 10.4.0. The "Auto-migrate compatible panels" link in particular will be displayed when the dashboard contains at least one of the following plugins:

• graph
• table-old
• grafana-piechart-panel
• grafana-worldmap-panel
• singlestat
• grafana-singlestat-panel

Here's a better screenshot showing it:

Will there be an option to revert the automigration (or will it still be required to save dashboard explicitly after the auto migration)?

I don't know the details regarding the auto migration feature, but from my testing the dashboard required a manual save before the migration was committed. So there's no option to revert the auto migration because it has to be saved manually by the user

[leeoniya]

So there's no option to revert the auto migration because it has to be saved manually by the user

yes, once it is saved there is no going back, unless you restore old database or if we offer a built-in way to undo db changes (such as retaining old versions somewhere else in the db). but this will only work until angular is removed anyhow.

i think the main issue with the inability to use a url for feature enablement in production environments is that to "undo" an unsaved migration is no longer a browser Back button away. we need to provide a way to clear the appropriate cookie or localStorage variable that we choose to implement instead of simply relying on browser url history.

[sympatheticmoose]

yes, once it is saved there is no going back, unless you restore old database or if we offer a built-in way to undo db changes (such as retaining old versions somewhere else in the db). but this will only work until angular is removed anyhow.

Couldn't you just restore the previous dashboard version? Or is the change persisted somewhere else beyond the dashboard.json?

[leeoniya]

Couldn't you just restore the previous dashboard version? Or is the change persisted somewhere else beyond the dashboard.json?

the dashboard.json is stored in the db. so if we already offer some way to restore previous dashboard versions, then sure. this is outside my wheelhouse. idk what we offer in terms of backend storage capabilities or how/where we expose this in the UI.

EDIT: yeah, i guess it exists :)

https://grafana.com/docs/grafana/latest/dashboards/build-dashboards/manage-version-history/

[xnyo]

Superseded by #84100

[grafana-delivery-bot]

This PR must be merged before a backport PR will be created.