Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VizTooltip: Remove use of LayoutItemContext #83542

Merged
merged 1 commit into from Feb 27, 2024
Merged

VizTooltip: Remove use of LayoutItemContext #83542

merged 1 commit into from Feb 27, 2024

Conversation

leeoniya
Copy link
Contributor

this extracts the viztooltip bits from the more general LayoutItemContext removal: #83465

@leeoniya leeoniya added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Feb 27, 2024
@leeoniya leeoniya requested a review from a team as a code owner February 27, 2024 19:07
@leeoniya leeoniya requested review from drew08t and removed request for a team February 27, 2024 19:07
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Feb 27, 2024
@grafana-pr-automation grafana-pr-automation bot added area/panel/timeseries The main time series Graph panel area/frontend labels Feb 27, 2024
baldm0mma
baldm0mma approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@baldm0mma baldm0mma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks nothing locally, and tooltips work as expected in all tested panel types.

@leeoniya leeoniya merged commit 5c60f4d into main Feb 27, 2024
27 checks passed
@leeoniya leeoniya deleted the leeoniya/viztooltip-no-anno-LayoutItemContext branch February 27, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baldm0mma baldm0mma baldm0mma approved these changes

@drew08t drew08t Awaiting requested review from drew08t drew08t is a code owner automatically assigned from grafana/dataviz-squad

Assignees
No one assigned
Labels
area/frontend area/panel/timeseries The main time series Graph panel no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leeoniya @baldm0mma @fabrizio-grafana