New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Remove deprecated components from dashboard import pages #83747
Conversation
maxWidth?: number | 'none'; | ||
} | ||
|
||
export function Form<T extends FieldValues>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is the point of this move that the other one in grafana/ui is deprecated? Do we expect people to have new use cases for the use of this Form
? Just wondering why the need to duplicate if we will still keep the other deprecated Form
for the foreseeable future anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal is to remove it from grafana/ui, there's nothing wrong with the component itself, just its dependence on reack-hook-form. That's why I think it's fine to have it in core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that's fair! I guess my main question is what is the plan for deletion? Do we know how many places it is used outside of grafana repo? Just wondering how long we will have this duplicated code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really gonna be duplicated code, this component is already a bit different from the one in grafana/ui and should be used from now on. Deleting the component from grafana/ui will be a bit more challenging as we don't have good data where it can be used, plus deleting it might break some unmaintained plugins which are still used. I'd like to get rid of it with the Grafana 11 release, but that might prove not feasible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Just wanted to make sure we had some plan to delete that one 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
What is this feature?
Part of #81226
Special notes for your reviewer:
Please check that: