VizTooltips: Heatmap fixes and improvements #83876
Conversation
grafana-pr-automation
bot
added
area/panel/timeseries
leeoniya
changed the title
| @@ -56,7 +56,7 @@ export const TimeSeriesTooltip = ({ | |||
| seriesIdx, | |||
| mode, | |||
| sortOrder, | |||
| (field) => field.type === FieldType.number | |||
| (field) => field.type === FieldType.number || field.type === FieldType.enum | |||
| focus: { | ||
| prox: 1e3, | ||
| dist: (u, seriesIdx) => (hRect?.sidx === seriesIdx ? 0 : Infinity), | ||
| }, |
There was a problem hiding this comment.
heatmap cell hover prox fix
| @@ -85,7 +85,7 @@ export const getContentItems = ( | |||
| ): VizTooltipItem[] => { | |||
| let rows: VizTooltipItem[] = []; | |||
|
|
|||
| let allNumeric = false; | |||
| let allNumeric = true; | |||
| @@ -772,6 +777,8 @@ export function heatmapPathsPoints(opts: PointsBuilderOpts, exemplarColor: strin | |||
| let fillPaths = [points]; | |||
| let fillPalette = [exemplarColor ?? 'rgba(255,0,255,0.7)']; | |||
|
|
|||
| let yShift = yLayout === HeatmapCellLayout.le ? -0.5 : yLayout === HeatmapCellLayout.ge ? 0.5 : 0; | |||
There was a problem hiding this comment.
this fixes vertical exemplar positioning in each cell. previously we assumed le (cell down from tick), but with ordinal it is centered, and can be manually set as well via panel opts.
| yVal -= 0.5; // center vertically in bucket (when tiles are le) | ||
| // y-randomize vertically to distribute exemplars in same bucket at same time | ||
| let randSign = Math.round(Math.random()) * 2 - 1; | ||
| yVal += randSign * 0.5 * Math.random(); |
There was a problem hiding this comment.
this removes exemplar y position randomization within each cell and provides stability, but also maybe overlap. probably a better trade-off. we can look at clustering or multi-hover in the future.
There was a problem hiding this comment.
- timeseries tooltip was not showing enum type fields
- fixes numeric tooltip sorting (for real this time)
- heatmap tooltip was only activating within 30px proximity to y-center of each cell
- heatmap data links code was slow and did not support field labels
- [-] tooltips work as expected when
newVizTooltipsFF is toggled on and off - for this I did notice one thing: when hovering a value with the old tooltips, the color scale at the bottom would display the hovered value on the range, but with the new tooltips, this functionality seems to be missing. Is this expected?
yes, this is expected for now. this was the only panel with some kind of live legend-tooltip behavior, so was too much of a snowflake to keep in right now. we will revisit this concept holistically for all panels as part of the legends work. the live color scale was moved into the tooltip as a toggle-able option in panel edit (same as live histogram in tooltip). |
fixes:
enumtype fieldsthis refactors code related to: