Histogram: Fix 'combine' option & legend rendering #84026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develer
approved these changes
Mar 6, 2024
leeoniya
added
no-backport
torkelo
approved these changes
Mar 6, 2024
nmarrs
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we currently reuse PlotLegend in Histogram panel, which expects
field.state.originthat maps back to original frame, otherwise it renders no series. bizarrely, it causesVizLayoutto not call its render prop, and does not render the viz at all. even more strange is that anulllegend does not cause the viz rendering failure.repro steps are easy:
testdatadata sourcewithout this PR the panel renders nothing due to PlotLegend having no items.