Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaveDashboardForm: Remove deprecated Form usage #84172

Merged
merged 3 commits into from Mar 26, 2024
Merged

Conversation

Clarity-89
Copy link
Contributor

What is this feature?

Remove deprecated Form component usage from SaveDashboardForm.

Which issue(s) does this PR fix?:

Part of #81226

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Clarity-89 Clarity-89 added the no-changelog Skip including change in changelog/release notes label Mar 11, 2024
@Clarity-89 Clarity-89 added this to the 11.0.x milestone Mar 11, 2024
@Clarity-89 Clarity-89 self-assigned this Mar 11, 2024
@Clarity-89 Clarity-89 requested a review from a team as a code owner March 11, 2024 11:35
@Clarity-89 Clarity-89 requested review from axelavargas and oscarkilhed and removed request for a team March 11, 2024 11:35
@torkelo
Copy link
Member

torkelo commented Mar 21, 2024

this form will soon be removed, the scenes version is not using deprecated Form https://github.com/grafana/grafana/blob/main/public/app/features/dashboard-scene/saving/SaveDashboardForm.tsx

so question is is worth updating it now?

@Clarity-89
Copy link
Contributor Author

this form will soon be removed, the scenes version is not using deprecated Form https://github.com/grafana/grafana/blob/main/public/app/features/dashboard-scene/saving/SaveDashboardForm.tsx

so question is is worth updating it now?

It's a relatively minor change so I think we'd just do it. This is one of the two PRs left to eliminate Form usage from grafana/UI before v11 release.

@grafanabot
Copy link
Contributor

❌ Failed to run Playwright plugin e2e tests.

Click here to browse the Playwright report and trace viewer.
For information on how to run Playwright tests locally, refer to the Developer guide.

@Clarity-89 Clarity-89 merged commit d105323 into main Mar 26, 2024
14 checks passed
@Clarity-89 Clarity-89 deleted the from/save-db-form branch March 26, 2024 12:14
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 11.0.x, 11.1.x Mar 26, 2024
@ashharrison90 ashharrison90 modified the milestones: 11.1.x, 11.0.0-preview Apr 15, 2024
@ashharrison90 ashharrison90 added product-approved Pull requests that are approved by product/managers and are allowed to be backported backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 15, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 15, 2024
* SaveDashboardForm: Remove deprecated Form usage

* Update

(cherry picked from commit d105323)
ashharrison90 pushed a commit that referenced this pull request Apr 15, 2024
SaveDashboardForm: Remove deprecated Form usage (#84172)

* SaveDashboardForm: Remove deprecated Form usage

* Update

(cherry picked from commit d105323)

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes product-approved Pull requests that are approved by product/managers and are allowed to be backported
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants