Saga-icons: Switch to ESM #84875
Merged
Saga-icons: Switch to ESM #84875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
requested review from
academo,
joshhunt,
JoaoSilvaGrafana and
jackw
and removed request for
a team
Clarity-89
added
the
no-changelog
Clarity-89
commented
Mar 21, 2024
| @@ -6,8 +6,8 @@ module.exports = { | |||
| typescript: true, | |||
| jsxRuntime: 'automatic', | |||
| outDir: './src/icons-gen', | |||
| template: require('./templates/icon'), | |||
| indexTemplate: require('./templates/index'), | |||
| template: require('./templates/icon.cjs'), | |||
There was a problem hiding this comment.
Svgr doesn't support ESM config files, so we need to use cjs extension.
joshhunt
approved these changes
Mar 26, 2024
ashharrison90
added
product-approved
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
(cherry picked from commit 0f68587)
ashharrison90
pushed a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Build the icons package as an ESM module.
Which issue(s) does this PR fix?: