E2C: Migration summary #84890
Merged
E2C: Migration summary #84890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
requested review from
ashharrison90 and
eledobleefe
and removed request for
a team
ashharrison90
approved these changes
Mar 21, 2024
Clarity-89
reviewed
Mar 21, 2024
joshhunt
force-pushed
the
joshhunt/e2c-migration-summary
branch
from
94d3c85
to
a15bc5f
Compare
Clarity-89
reviewed
Mar 21, 2024
| alignItems="center" | ||
| justifyContent="space-between" | ||
| > | ||
| <Stack gap={4} alignItems="center"> |
There was a problem hiding this comment.
Suggested change
| <Stack gap={4} alignItems="center"> |
This Stack is not needed anymore.
There was a problem hiding this comment.
hm yeah you're technically right for the current state, I guess 😅
There was a problem hiding this comment.
i sympathise cause i know from the design this will be needed fairly imminently 😄
ashharrison90
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Migration Summary box to the top of Migrate to Cloud to show the current connected stack, disconnect, and to start the migration.
startMigrationAPI mutation. It doesn't really do anything, not even a mocked behaviour. I figured this is more dependant on real functionality, so I think this is fine for now.Fixes #84553