Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InteractiveTable: Add expand all to column #84966

Merged
merged 3 commits into from Mar 22, 2024
Merged

InteractiveTable: Add expand all to column #84966

merged 3 commits into from Mar 22, 2024

Conversation

abannachGrafana
Copy link
Contributor

@abannachGrafana abannachGrafana commented Mar 22, 2024 •
edited

What is this feature?

  • <InteractiveTable /> component.
    • add optional expand all capability
  • New icons for table expand and collapse all

Why do we need this feature?

  • Depending on your table needs if rows are expandable you may want to expand all of them.

Who is this feature for?

  • Users of the <InteractiveTable /> component

What issue(s) does this PR fix?

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

expand-all-storybook

@abannachGrafana abannachGrafana requested review from a team as code owners March 22, 2024 03:43
@abannachGrafana abannachGrafana requested review from mckn, Clarity-89 and L-M-K-B and removed request for a team March 22, 2024 03:43
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Mar 22, 2024
abannachGrafana
abannachGrafana commented Mar 22, 2024
View reviewed changes
public/img/icons/unicons/table-collapse-all.svg Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG provided by UX

abannachGrafana
abannachGrafana commented Mar 22, 2024
View reviewed changes
public/img/icons/unicons/table-expand-all.svg Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG provided by UX

Clarity-89
Clarity-89 reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@Clarity-89 Clarity-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! 🎉 Left a few minor comments.

packages/grafana-ui/src/components/InteractiveTable/InteractiveTable.test.tsx Outdated Show resolved Hide resolved
packages/grafana-ui/src/components/InteractiveTable/InteractiveTable.test.tsx Outdated Show resolved Hide resolved
packages/grafana-ui/src/components/InteractiveTable/InteractiveTable.test.tsx Outdated Show resolved Hide resolved
packages/grafana-ui/src/components/InteractiveTable/InteractiveTable.test.tsx Outdated Show resolved Hide resolved
packages/grafana-ui/src/components/InteractiveTable/Expander/index.tsx Outdated Show resolved Hide resolved
packages/grafana-ui/src/components/InteractiveTable/Expander/index.tsx Show resolved Hide resolved
packages/grafana-ui/src/components/InteractiveTable/InteractiveTable.tsx Show resolved Hide resolved
Clarity-89
Clarity-89 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@Clarity-89 Clarity-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise looks good 🚀

packages/grafana-ui/src/components/InteractiveTable/InteractiveTable.tsx Outdated Show resolved Hide resolved
@Clarity-89 Clarity-89 merged commit 16737c5 into main Mar 22, 2024
18 checks passed
@Clarity-89 Clarity-89 deleted the adam.bannach/expand-all branch March 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clarity-89 Clarity-89 Clarity-89 approved these changes

@mckn mckn Awaiting requested review from mckn mckn is a code owner automatically assigned from grafana/plugins-platform-frontend

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B L-M-K-B is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
add to changelog area/frontend no-backport Skip backport of PR
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abannachGrafana @Clarity-89 @fabrizio-grafana