Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InteractiveTable: React, less hooks rendered than previous render #85043

Merged
merged 1 commit into from Mar 25, 2024

Conversation

abannachGrafana
Copy link
Contributor

What is this feature?

There was an error state introduced where pagination could be enabled or disabled based on data length change.

Why do we need this feature?

If using pagination and your implementation allows for filtering of the table data. An exception would be through due to react rendering more (or less) hooks than the previous render.

Which issue(s) does this PR fix?

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@abannachGrafana abannachGrafana added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Mar 23, 2024
@abannachGrafana abannachGrafana requested a review from a team as a code owner March 23, 2024 19:08
@abannachGrafana abannachGrafana requested review from joshhunt and JoaoSilvaGrafana and removed request for a team March 23, 2024 19:08
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Mar 23, 2024
@abannachGrafana abannachGrafana changed the title Fix InteractiveTable: React-hooks error if data length switches from above or below pageSize Fix InteractiveTable: React, less hooks rendered than previous render Mar 23, 2024
@abannachGrafana abannachGrafana modified the milestone: 11.0.x Mar 23, 2024
@Clarity-89 Clarity-89 merged commit d7f739c into main Mar 25, 2024
30 checks passed
@Clarity-89 Clarity-89 deleted the adam.bannach/fix-pagination-hook branch March 25, 2024 11:53
@ashharrison90 ashharrison90 modified the milestones: 11.0.x, 11.1.x Mar 25, 2024
@ashharrison90 ashharrison90 modified the milestones: 11.1.x, 11.0.0-preview Apr 15, 2024
@ashharrison90 ashharrison90 added type/bug backport v11.0.x Mark PR for automatic backport to v11.0.x and removed no-backport Skip backport of PR labels Apr 15, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 15, 2024
…#85043)

fix: react-hooks error if data length switches from above or below pageSize
(cherry picked from commit d7f739c)
ashharrison90 pushed a commit that referenced this pull request Apr 15, 2024
…ous render (#86113)

Fix InteractiveTable: React, less hooks rendered than previous render (#85043)

fix: react-hooks error if data length switches from above or below pageSize
(cherry picked from commit d7f739c)

Co-authored-by: Adam Bannach <113929542+abannachGrafana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants