Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datatrails: throttle the resetting of yaxis #85117

Merged
merged 1 commit into from Mar 25, 2024

Conversation

darrenjaneczek
Copy link
Contributor

@darrenjaneczek darrenjaneczek commented Mar 25, 2024

What is this feature?

Reduces the resetting of the yaxis ranges by:

  • checking if an actual change took place
  • throttling the event that notifies the change

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@darrenjaneczek darrenjaneczek added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Mar 25, 2024
@darrenjaneczek darrenjaneczek self-assigned this Mar 25, 2024
Copy link
Contributor

@leeoniya leeoniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test, but code looks fine 🙈

@darrenjaneczek darrenjaneczek enabled auto-merge (squash) March 25, 2024 19:03
@leeoniya leeoniya added this to the 11.0.x milestone Mar 25, 2024
@darrenjaneczek darrenjaneczek force-pushed the datatrails/throttle-yaxis-reset branch from 5c92b17 to 09b89b3 Compare March 25, 2024 20:59
@darrenjaneczek darrenjaneczek merged commit 2e06677 into main Mar 25, 2024
15 checks passed
@darrenjaneczek darrenjaneczek deleted the datatrails/throttle-yaxis-reset branch March 25, 2024 23:33
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 11.0.x, 11.1.x Mar 25, 2024
@darrenjaneczek darrenjaneczek added backport v11.0.x Mark PR for automatic backport to v11.0.x and removed no-backport Skip backport of PR labels Mar 29, 2024
Copy link
Contributor

Hello @darrenjaneczek!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@darrenjaneczek darrenjaneczek added backport v11.0.x Mark PR for automatic backport to v11.0.x and removed backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 2, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 2, 2024
fix: throttle the resetting of yaxis
(cherry picked from commit 2e06677)
darrenjaneczek added a commit that referenced this pull request Apr 3, 2024
datatrails: throttle the resetting of yaxis (#85117)

fix: throttle the resetting of yaxis
(cherry picked from commit 2e06677)

Co-authored-by: Darren Janeczek <38694490+darrenjaneczek@users.noreply.github.com>
@ashharrison90 ashharrison90 modified the milestones: 11.1.x, 11.0.0-preview Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants