Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pa11y: Decrease error thresholds for PRs #85178

Merged
merged 2 commits into from Mar 27, 2024
Merged

Pa11y: Decrease error thresholds for PRs #85178

merged 2 commits into from Mar 27, 2024

Conversation

tskarhed
Copy link
Contributor

What is this feature?

Decreases error thresholds for PRs, so we don't accidentally add a11y errors. Let me know if there is some caveat to this.

@tskarhed tskarhed requested a review from a team as a code owner March 26, 2024 14:27
@tskarhed tskarhed requested review from Clarity-89 and JoaoSilvaGrafana and removed request for a team March 26, 2024 14:27
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Mar 26, 2024
@tskarhed tskarhed added the no-changelog Skip including change in changelog/release notes label Mar 26, 2024
@tskarhed tskarhed merged commit 6248bdd into main Mar 27, 2024
14 checks passed
@tskarhed tskarhed deleted the pa11y-lower-threshold branch March 27, 2024 11:29
@ashharrison90 ashharrison90 modified the milestones: 11.1.x, 11.0.0-preview Apr 16, 2024
@ashharrison90 ashharrison90 added product-approved Pull requests that are approved by product/managers and are allowed to be backported backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 16, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Apr 16, 2024
@tskarhed @grafana-delivery-bot
Pa11y: Decrease error thresholds for PRs (#85178)
86139c3 
* Pa11y-pr: lower error thresholds

* Increase threshold for alerting

(cherry picked from commit 6248bdd)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Apr 16, 2024
Merged
ashharrison90 pushed a commit that referenced this pull request Apr 16, 2024
@grafana-delivery-bot @tskarhed
[v11.0.x] Pa11y: Decrease error thresholds for PRs (#86297)
6d40282 
Pa11y: Decrease error thresholds for PRs (#85178)

* Pa11y-pr: lower error thresholds

* Increase threshold for alerting

(cherry picked from commit 6248bdd)

Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>
@tskarhed tskarhed added the type/accessibility Accessibility problem / enhancement label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clarity-89 Clarity-89 Clarity-89 approved these changes

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes product-approved Pull requests that are approved by product/managers and are allowed to be backported type/accessibility Accessibility problem / enhancement
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tskarhed @Clarity-89 @ashharrison90