StateTimeline: Fix data links causing unrendering of string fields #85260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
added
type/bug
area/panel/state-timeline
no-changelog
leeoniya
requested review from
baldm0mma and
drew08t
and removed request for
a team
|
This PR must be merged before a backport PR will be created. |
|
This PR must be merged before a backport PR will be created. |
baldm0mma
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a regression introduced in #83654 causing string fields not to render in GraphNG-based panels when panel data links are added. the only panel that currently renders string fields is StateTimeline.
can be reproduced in http://localhost:3000/d/mIJjFy8Kz/timeline-demo?orgId=1
https://github.com/grafana/grafana/blob/main/devenv/dev-dashboards/panel-timeline/timeline-modes.json
Kooha-2024-03-27-08-14-24.webm