Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] feat: Defaults image.tag to chart appVersion #1406

Merged
merged 1 commit into from May 26, 2022

Conversation

KENNYSOFT
Copy link
Contributor

There are many cases that PR or chart release only changed appVersion and left image.tag value (may not be the whole):

It seems first-comers can make mistakes easily, so I've changed the tag used by pod image definition defaults to chart appVersion.

Description based on: https://github.com/argoproj/argo-helm/blob/1492575ee07aebdbdc22ff4d16da7455fe3e1b1e/charts/argo-cd/values.yaml#L16

Signed-off-by: Hyeonmin Park <hyeonmin.park@kennysoft.kr>
@KENNYSOFT KENNYSOFT changed the title feat(grafana): Defaults image.tag to chart appVersion [grafana] feat: Defaults image.tag to chart appVersion May 23, 2022
@zanhsieh zanhsieh merged commit a0ca85f into grafana:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants