Plugin E2E: Use new e2e selectors #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
changed the title
sunker
added
minor
sunker
commented
Mar 20, 2024
| @@ -37,6 +37,7 @@ nx-cloud.env | |||
|
|
|||
| # End to End tests | |||
| playwright-report/ | |||
| packages/plugin-e2e/test-results/ | |||
There was a problem hiding this comment.
All of a sudden Playwright started generating zip files related to reports. Anyway, this dir should definitely be ignored.
sunker
commented
Mar 20, 2024
| annotationsChoosePanelInput: string; | ||
| }; | ||
| Tooltip: { | ||
| container: string; |
There was a problem hiding this comment.
These selectors were not used in plugin-e2e.
mckn
approved these changes
Mar 26, 2024
|
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR replaces a few unsafe locators with proper selectors defined grafana/e2e-selectors (and in the versioned selectors in plugin-e2e). The new selectors where recently added to the main branch of Grafana, hence we'll have to use the unsafe locator for versions before 11. This should be fine though as no one will ever backport selector updates to older version of Grafana.
Also updating related docs.
Which issue(s) this PR fixes:
Fixes #724
Special notes for your reviewer:
The selectors were added to Grafana in the following PRs.
grafana/grafana#83248
grafana/grafana#83246
grafana/grafana#83240
grafana/grafana#83230
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.3.0-canary.833.13a3f6f.0 npm install @grafana/plugin-e2e@0.23.0-canary.833.13a3f6f.0 # or yarn add @grafana/create-plugin@4.3.0-canary.833.13a3f6f.0 yarn add @grafana/plugin-e2e@0.23.0-canary.833.13a3f6f.0