Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for rendering flat numbers in addr:flats #1665

Closed
wants to merge 1 commit into from

Conversation

derickr
Copy link
Contributor

@derickr derickr commented Jul 19, 2015

This patch adds support for rendering addr:flats instead of addr:housename - which makes a lot of sense if you see things like:

before

The nodes all have addr:flats, addr:housename and addr:street - but the housename shows up 20 times or so.

With this patch, it renders like:

after

I've made the number one point smaller than real house numbers, but I'm happy to have it render differently - just thought it would be nice that it shows up. It makes a lot of sense in this area as there are so many instances. Annoyingly, it requires a new column in the database.

@matkoniecz matkoniecz added this to the 3.x - Needs upgrade to openstreetmap-carto.style milestone Jul 19, 2015
@pnorman
Copy link
Collaborator

pnorman commented Jul 21, 2015

Closing. Still working out what tags will be in columns vs hstore, but addr:flats is extremely unlikely to be in a column, so this PR would need complete rewriting at that time. Same as #605 (comment)

Some things to consider when it comes time

  • what if all the addresses have a flat? Then housenumber/housename wouldn't appear at all. Is this a common situation?
  • flat numbers shouldn't be a higher label placement priority than housenumbers. the right approach is probably to filter out flat numbers from the housenumber/housenamelayer, this way if there is a conflict between a nearby housenumber/housename and a flat number, the latter gets displayed.
  • Should all three address layers be combined into one?

I suggest adding comments on #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants