Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked @jusjoheinz 's TMC support from https://github.com/justjoheinz/grbl/tree/trinamic into master of Grbl 0.9J #859

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2015

Fixed spindle, endstops too (moved endstops to Analog pins
D0 = RX
D1 = TX
D2 = x step
D3 = y step
D4 = z step
D5 = x dir
D6 = y dir
D7 = z dir
D8 = spindle dir
D9 = spindle pwm/en
D10 = Coolant
D11 = MOSI (SPI)
D12 = MISO (SPI)
D13 = SCK (SPI)
A0 = CS-x TMC26x
A1 = CS-y TMC26x
A2 = CS-z TMC26x
A3 = X-end
A4 = Y-end
A5 = Z-end / probe

@chamnit
Copy link
Member

chamnit commented Nov 30, 2015

@openhardwarecoza : Thanks Peter! I'll take a look at this later this week. There's quite a lot to digest.

@tmpvar
Copy link
Contributor

tmpvar commented Nov 30, 2015

@openhardwarecoza looks like you let some of your editor's temporary files get added to this patchset (e.g., Makefile~) you'll probably want to remove those to help @chamnit in the review process.

@ghost
Copy link
Author

ghost commented Dec 1, 2015

Oh gosh, sorry you are right @tmpvar!

@ghost
Copy link
Author

ghost commented Dec 1, 2015

PS: Prototype boards should be in in about two weeks. (https://openhardwarecoza.wordpress.com/2015/11/29/raspberry-pi-zero-grbl-tmc2660-controller-update/) Hold off until merging in.

I may have pulled the PR trigger too quickly (:
I am going to add some more #ifdefs so it doesnt screw up any default settings. I dont think I did (i have ifdefs for all the pin swaps, pwm register changes (moved spindle pwm to D9) and removal of the control port. But let me just run through it once more.

All the pin swaps, etc have been tested, I just haven't real-world tested the TMC2660s (no hardware on hand to test with yet until those boards come in)

I have one funny bug left on the PWM though. On bootup of grbl (after bootloader - while grbl is already running) the PWM pin is 255. I need to do a M3 S0 in startup gcode and then power on spindle controller. Still bumping my head against that. In my config though I use the Dir as Enable config so I just AND together PWM and Enable. But still, needs to be fixed

@ghost
Copy link
Author

ghost commented Dec 5, 2017

Are there any chances of this being implemented at some point? Would be wonderful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants