Isolate the contents of scriptdownloader.js in a private scope.

Signed-off-by: Johan Sundström <oyasumi+github@gmail.com>
greasemonkey · Aug 13, 2009 · 85cd63e · 85cd63e
1 parent c31bd4d
commit 85cd63e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/content/browser.js b/content/browser.js
@@ -218,7 +218,7 @@ GM_BrowserUI.startInstallScript = function(uri, timer) {
     return;
   }
 
-  this.scriptDownloader_ = new ScriptDownloader(window, uri, this.bundle);
+  this.scriptDownloader_ = new GM_ScriptDownloader(window, uri, this.bundle);
   this.scriptDownloader_.startInstall();
 };
 

diff --git a/content/scriptdownloader.js b/content/scriptdownloader.js
@@ -1,3 +1,7 @@
+// This anonymous function exists to isolate generic names inside it to its
+// private scope.
+(function() {
+
 function ScriptDownloader(win, uri, bundle) {
   this.win_ = win;
   this.uri_ = uri;
@@ -10,6 +14,9 @@ function ScriptDownloader(win, uri, bundle) {
   this.tempFiles_ = [];
 }
 
+// Export this one important value to the global namespace.
+window.GM_ScriptDownloader=ScriptDownloader;
+
 ScriptDownloader.prototype.startInstall = function() {
   this.installing_ = true;
   this.startDownload();
@@ -279,3 +286,5 @@ PersistProgressListener.prototype.onStateChange =
       this.onFinish();
     }
   };
+
+})();