New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(in e10s window) Greasemonkey doesn't intercept some userscript links in GitHub (by presenting the installation dialog), though they end with 'user.js' #2280
Comments
I don't think it was necessary to close... https://github.com/jerone/UserScripts/blob/master/Github_News_Feed_Filter/Github_News_Feed_Filter.user.js |
I just reopened it (closed by mistake) |
See: https://github.com/greasemonkey/greasemonkey/blob/3.4.1/content/browser.js#L34 e10s on: The listener will not start.
e10s off: The listener starts. |
I've been having trouble understanding/confirming this issue. I've merged @janekptacijarabaci 's proposed fix and would appreciate feedback on whether 3.5beta3 helps: https://addons.mozilla.org/firefox/downloads/file/356688/greasemonkey-3.5beta3-fx.xpi?src=devhub |
In the originally reported case of URL: The URL already ends in |
Fixing this bug has to include not breaking #1875. Refreshing myself on the detail of that one. Trying to edit a
The code committed to fix #1875 implies that we were intercepting the POST in step 3, REJECTing it because it looks like a user script URL, and then that breaks the POST data. The change was to detect that seemingly unique case and instead ACCEPT the request that was probably a POST (though we don't have any context to know for certain that it is a POST). |
I've created a test script to reproduce this issue, without using public GitHub: https://gist.github.com/arantius/b57b7c0fc467237d0062 And yes, I've confirmed the situation back from #1875 -- the solution (really, workaround) to that is the cause of this. The proper fix for this is to fix #1875 without causing this side effect. |
My best idea so far, but I don't like how big a change it would be, is to switch from |
I've started working on the approach described immediately above. A few false starts were frustrating, but now I've made some good/interesting progress. |
Whoops, the above was e10s disabled. Enabled, giant mess. Plus http-on-modify doesn't see local files. |
Some snippets for my own records: 1
2
Which are "useful" but don't actually do what I need in context of the work in progress so far ( arantius/greasemonkey@master...install-observer ) for this issue. |
The core of the problem I'm facing: http://stackoverflow.com/questions/35344579/ |
Ah! I've rearranged the problem into something that seems workable. The And the critical new bit: I can not only . That and restoring(/keeping) the nsIContentPolicy to see local files (HTTP observer only sees HTTP) is looking like it works. Removes some janky existing code, but needs to be tested, definitely. Especially the less common features and edge cases around installs. |
Thanks, that was unintentional, one of the many things I tried and removed, failed to clean up. |
I'm just noticing now that even though |
I've just pushed what should be a fix for this, but it's a big change. I would greatly appreciate any help testing that it works comprehensively; build 3.8beta1 includes this change: https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/versions/?page=1#version-3.8beta1 |
|
@janekptacijarabaci Please please use more words. I don't know what you mean at all for point 2. |
Tested on: This bug is back ("[e10s off] Two install dialogs"): But only version 44.0.2-. The issue has been fixed in newer versions of Firefox (45.0beta1+). I'm sorry. Last bad: 2016-02-01 First good: 2016-02-02 |
That's probably why I didn't catch it. And Firefox 45 will be stable soon, so I think I'm comfortable living with this minor usability issue until it is. |
(using FF Nightly 43.0a1 x64, with GM 3.4.1, in a e10s window)
For example:
the link that is the
Raw
button in this pageThe URL is:
https://github.com/jerone/UserScripts/raw/63b0f7fd9818c780d05635c9f5acb26afe2d05ef/Github_News_Feed_Filter/Github_News_Feed_Filter.user.js
The same link, linkified here is intercepted ok.
On the other hand, in a non e10s window (and in FF40 w GM 3.4.1) the link is intercepted ok.
For reference, for that same script (in a e10s window), the installation gets intercepted ok
if you either press the
Install
button in the script's main page(master branch)(or if you press the
Github_News_Feed_Filter.user.js
link and then theRaw
button in that link).The text was updated successfully, but these errors were encountered: