New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Monkey Menu to look and behave like native FF #2805
Conversation
aa91ee2
to
37ec6d9
Compare
It should also be noted that sub text can be easily applied to a menu item. To denote shortcuts (should the be implemented) or other information. This can be done by adding an For example adjusting the homepage link to: <a href="#https://www.greasemonkey.net/" class="subview-item" after="CTRL+Sample"> |
37ec6d9
to
18fa96c
Compare
If the menu needs original attributes, you can use However, I think that making it possible to also write |
The reason I used the "after" is that it's the exact same method used in FF menus. I could change it if you think it's better to do something else. |
I see. In that case, I suggest “aria-keyshortcuts” for now. After this, how about adding CSS which corresponds to a proper attribute as needed? |
Disregarding the point that the |
18fa96c
to
7f1d211
Compare
I believe I figured out the rendering issue. It has to due with a special fill flag set in the |
afea6fd
to
73f9ae3
Compare
Overall I like this except it's stretching the user scripts' icons. |
Oh, didn't really notice. Although, on closer inspection I'd suggest to keep the 'wider' icons. I feel they look better as they 'fill out' the icon area. I'll look into updating and posting comparisons. |
And by 'keep', I mean replace the current default icon that's bundled with GM. The stretching will still be fixed so that scripts that provide their own icons won't be stretched. |
If you've got good art I'll happily review it, but for now I care about maintaining aspect ratio, and have found a good way to do so. |
I grabbed the latest. I noticed you removed the font size from the icons. Did you want to use the smaller icons? I set the size so that they'd be more comparable to FF icons, and the larger size cleans up / sharpens the details in most of the icons. |
Inadvertent; fixed. |
Fix other user scripts heading style in MM Refs #2805
Overhaul the styling to much more closely mimic FF 57 + menu / panel design. Also includes a similar transition effect as seen in native FF menus.