Error when uninstalling last script

[arantius]

If you have only one script installed and you uninstall it (specifically, I click "uninstall" then when clicking the back arrow) you get:

 e is not a function rivets.bundled.min.js:6

A failure somewhere in the rivets templating engine. A second click on the back button works.

[arantius]

Update: this is "last script in a section". So if you have only one "for this tab" or "other", this happens.

[Sxderp]

This has to do with using rv-unless for the script sections.

greasemonkey/src/browser/monkey-menu.html

Lines 30 to 31 in 18e21a4

	<div rv-unless="userScripts.active | empty">
	<heading>{'user_scripts_for_this_tab'|i18n}</heading>

greasemonkey/src/browser/monkey-menu.html

Lines 43 to 45 in 18e21a4

	<div rv-unless="userScripts.inactive | empty">
	<hr rv-unless="userScripts.active | empty">
	<heading>{'other_user_scripts'|i18n}</heading>

Changing the top <div>s to rv-hide solves the problem.

[arantius]

I'd prefer the behavior of unless (unneeded elements are not in the DOM at all, vs. hidden via CSS). Do you know why? Unless/if should work, shouldn't they?

[Sxderp]

I'm not entirely sure, but this and #2963 might be related to the following:
mikeric/rivets#452 (comment)

I haven't done any testing (related to why rv-if fails) and I only just now looked up the above issue (doing a search on rv-if problems). I only thought of changing the directive because I distinctly remember this working in some mockups (never published) some time ago.

[arantius]

That sure looks like a good explanation.