Fix matchpattern file: match
#2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TYPO: protcol |
Sxderp
force-pushed
the
fix-matchpattern-file-match
branch
from
13f83a4
to
d8ea161
Compare
Never happened. =-) |
arantius
reviewed
Jan 5, 2018
| = (pattern, urlStr) => assert.isNotOk(pattern.doMatch(new URL(urlStr))); | ||
| describe('invalid patterns', () => { | ||
| const newPattern = | ||
| pattern => { return () => new MatchPattern(pattern) }; |
There was a problem hiding this comment.
I think this fits on one line, but for all statements continued across >1 line, continuations should be indented 4 spaces.
Sxderp
added a commit
to Sxderp/greasemonkey
that referenced
this pull request
Jan 6, 2018
Sxderp
force-pushed
the
fix-matchpattern-file-match
branch
from
8a5e855
to
1370ac0
Compare
Sxderp
added a commit
to Sxderp/greasemonkey
that referenced
this pull request
Jan 6, 2018
Parsing of the pattern in regard to `file:` and hostname or lack thereofore have been changed to more properly reflect Google specification. https://developer.chrome.com/extensions/match_patterns
Sxderp
force-pushed
the
fix-matchpattern-file-match
branch
from
1370ac0
to
aa8d6d1
Compare
|
This is valuable, but only after #2693 . |
|
if only #2693 is done you can still use If you only do this, you get nothing. But yes, the two are closely related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't recall how I stumbled upon this, but I found out that
MatchPattern.jsdoesn't quite follow Google's specification.file:///foo*is a valid match pattern but the previous code would not allow it. A fix to the Regex solved that problem.Also added a bunch of tests.