Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@JsIgnore in a native @JsType should not be valid #9334

Closed
gkdn opened this issue May 10, 2016 · 2 comments
Closed

@JsIgnore in a native @JsType should not be valid #9334

gkdn opened this issue May 10, 2016 · 2 comments
Assignees
@rluble
Milestone
2.8

Comments

@gkdn
Copy link
Contributor

gkdn commented May 10, 2016 

@JsType(isNative = true)
public interface A {
  @JsIgnore
  B toB();
}

should fail. (See cl/120873646).
@gkdn gkdn added this to the 2.8 milestone May 10, 2016
@rluble
Copy link
Contributor

rluble commented May 25, 2016

Added a test that shows there is an error here. Maybe the type was not referenced in the cl and hence not even checked when the type was introduced.

review at: https://gwt-review.googlesource.com/#/c/14983

@rluble
Copy link
Contributor

rluble commented May 25, 2016

Probably the method was not referenced and because the checking is done after UnifyAST when it would be pruned if not referenced. That scenario is possibly fixed by https://gwt-review.googlesource.com/#/c/14941

@rluble rluble closed this as completed May 25, 2016
bauna pushed a commit to bauna/gwt that referenced this issue May 26, 2016
@rluble
Add JsInterop restriction test for @JsIngore on native interface.
0ba67f4 
Bug: gwtproject#9334
Change-Id: I45a80c4e7efe9ccc6473f11ecf5cc50bcf3b8684
Bug-Link: http://github.com/gwtproject/gwt/issues/9334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rluble rluble

Labels
None yet
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
3 participants
@jnehlmeier @gkdn @rluble