A particularly nasty bug that I fixed myself! (all the while learning about GitHub)

src/Subtext.Framework/Infrastructure/Installation/Scripts/StoredProcedures.sql

@@ -1126,6 +1126,8 @@ WHERE (c.CategoryID = @CategoryID OR @CategoryID IS NULL)
     AND (c.CategoryType = @CategoryType OR @CategoryType IS NULL)
     AND (c.BlogId = @BlogId OR @BlogId IS NULL)
     AND c.Active <> CASE @IsActive WHEN 0 THEN -1 else 0 END
+ORDER BY
+    c.Title
 
 
 GO

src/Subtext.Framework/Infrastructure/Routing/SubtextRouteExtensions.cs

@@ -233,9 +233,22 @@ public static Uri ToFullyQualifiedUrl(this VirtualPath virtualPath, Blog blog, s
             }
 
             var builder = new UriBuilder { Scheme = scheme, Host = blog.Host };
-            if (HttpContext.Current != null && HttpContext.Current.Request != null && HttpContext.Current.Request.Url.Port != 80)
+            if (HttpContext.Current != null
+                && HttpContext.Current.Request != null)
             {
-                builder.Port = HttpContext.Current.Request.Url.Port;
+                if (HttpContext.Current.Request.IsSecureConnection == true)
+                {
+                    builder.Scheme = "https";
+
+                    if (HttpContext.Current.Request.Url.Port != 443)
+                    {
+                        builder.Port = HttpContext.Current.Request.Url.Port;
+                    }
+                }
+                else if (HttpContext.Current.Request.Url.Port != 80)
+                {
+                    builder.Port = HttpContext.Current.Request.Url.Port;
+                }
             }
             return new Uri(builder.Uri, virtualPath);
         }

src/Subtext.Framework/Text/HtmlHelper.cs

@@ -18,6 +18,7 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.Specialized;
+using System.Diagnostics;
 using System.Globalization;
 using System.IO;
 using System.Text;
@@ -824,6 +825,17 @@ public static IList<string> ParseTags(this string html)
                     Uri url;
                     if (Uri.TryCreate(urlStr, UriKind.RelativeOrAbsolute, out url))
                     {
+                        if (url.IsAbsoluteUri == false)
+                        {
+                            // HACK: You can't access Segments property on
+                            // relative Uri
+                            url = new Uri(
+                                new Uri("http://foobar"),
+                                urlStr);
+                        }
+
+                        Debug.Assert(url.IsAbsoluteUri == true);
+
                         string[] seg = url.Segments;
                         string tag = HttpUtility.UrlDecode(seg[seg.Length - 1].Replace("/", ""));
 

src/Subtext.Framework/Tracking/Notification.cs

@@ -35,6 +35,7 @@
 
 #endregion
 
+using System;
 using Subtext.Framework.Components;
 using Subtext.Framework.Configuration;
 using Subtext.Framework.Routing;
@@ -64,9 +65,12 @@ public static void Run(Entry entry, Blog blog, BlogUrlHelper urlHelper)
 
             if (entry != null)
             {
+                VirtualPath blogUrl = urlHelper.BlogUrl();
+                Uri fullyQualifiedUrl = blogUrl.ToFullyQualifiedUrl(blog);
+
                 var notify = new Notifier
                 {
-                    FullyQualifiedUrl = urlHelper.BlogUrl(),
+                    FullyQualifiedUrl = fullyQualifiedUrl.AbsoluteUri,
                     BlogName = blog.Title,
                     Title = entry.Title,
                     PostUrl = urlHelper.EntryUrl(entry).ToFullyQualifiedUrl(blog),

src/Subtext.Framework/Tracking/TrackBackNotificationProxy.cs

@@ -72,7 +72,7 @@ public class TrackBackNotificationProxy
                     return SendPing(trackBackUrl, parameters);
                 }
             }
-            return true;
+            return false;
         }
 
         private static bool SendPing(Uri trackBackItem, string parameters)

src/Subtext.Framework/Tracking/TrackHelpers.cs

@@ -48,12 +48,16 @@ namespace Subtext.Framework.Tracking
     /// </summary>
     public static class TrackHelpers
     {
-        //Text to insert into a file with pinkback service location
-        public static string GetPingPackTag(BlogUrlHelper urlHelper)
+        //Text to insert into a file with pingback service location
+        public static string GetPingbackTag(BlogUrlHelper urlHelper, Entry entry)
         {
+            VirtualPath blogUrl = urlHelper.BlogUrl();
+            Uri absoluteUrl = blogUrl.ToFullyQualifiedUrl(entry.Blog);
+
             return string.Format(CultureInfo.InvariantCulture,
-                                 "<link rel=\"pingback\" href=\"{0}Services/Pingback.aspx\"></link>",
-                                 urlHelper.BlogUrl());
+                "<link rel=\"pingback\" href=\"{0}Services/Pingback/{1}.aspx\"></link>",
+                absoluteUrl.AbsoluteUri,
+                entry.Id);
         }
 
         //Body of text to insert into a post with Trackback

src/Subtext.Framework/UI/Skinning/StyleSheetElementCollectionRenderer.cs

@@ -126,9 +126,14 @@ public static string GetStylesheetHrefPath(string skinPath, Style style)
             {
                 return HttpHelper.ExpandTildePath(style.Href);
             }
-            return style.Href.StartsWith("/") || style.Href.StartsWith("http://") || style.Href.StartsWith("https://")
-                       ? style.Href
-                       : skinPath + style.Href;
+            else if (IsStyleRemote(style) == true)
+            {
+                return style.Href;
+            }
+            else
+            {
+                return skinPath + style.Href;
+            }
         }
 
         /// <summary>
@@ -358,8 +363,9 @@ public static bool CanStyleBeMerged(Style style)
 
         private static bool IsStyleRemote(Style style)
         {
-            if (style.Href.StartsWith("http://", StringComparison.OrdinalIgnoreCase) ||
-               style.Href.StartsWith("https://", StringComparison.OrdinalIgnoreCase))
+            if (style.Href.StartsWith("/")
+                || style.Href.StartsWith("http://", StringComparison.OrdinalIgnoreCase)
+                || style.Href.StartsWith("https://", StringComparison.OrdinalIgnoreCase))
             {
                 return true;
             }

src/Subtext.Web/Routes.cs

@@ -125,6 +125,7 @@ public static void RegisterRoutes(SubtextRouteMapper routes)
 
 
         routes.MapControls("tag", "tags/{tag}/default.aspx", null, new[] { "TagEntryList" });
+        routes.MapControls("tag-default", "tags/{tag}", null, new[] { "TagEntryList" });
         routes.MapControls("tag-cloud", "tags/default.aspx", null, new[] { "FullTagCloud" });
         routes.MapHttpHandler<RssTagHandler>("tag-rss", "tags/{tag}/rss.aspx");
 

src/Subtext.Web/Scripts/common.js

@@ -41,7 +41,9 @@ function endRequest(sender, args)
     if (button) 
     {
         button.disabled = false;
-        button.value = button.oldValue;
+        if (button.oldValue && button.oldValue != '') {
+            button.value = button.oldValue;
+        }
         if (button.className == 'button-disabled') 
         {
             button.className = 'buttonSubmit';

src/Subtext.Web/UI/Controls/StoryList.cs

@@ -18,6 +18,7 @@
 using System;
 using System.Collections.Generic;
 using System.Globalization;
+using System.Web;
 using Subtext.Framework;
 using Subtext.Framework.Components;
 using Subtext.Framework.Data;
@@ -54,8 +55,18 @@ protected override void OnLoad(EventArgs e)
 
                 if (lc == null)
                 {
-                    HttpHelper.SetFileNotFoundResponse();
-                    return;
+                    // When running under Medium trust, calling HttpHelper.SetFileNotFoundResponse() causes an exception
+                    // while attempting to read the system.web/customErrors section of the Web.config file
+                    // ("System.Security.SecurityException: Request for the permission of type
+                    // 'System.Configuration.ConfigurationPermission, System.Configuration, Version=2.0.0.0, Culture=neutral,
+                    // PublicKeyToken=b03f5f7f11d50a3a' failed.").
+                    //
+                    // Therefore, just throw 404 HttpException instead.
+                    //
+                    //HttpHelper.SetFileNotFoundResponse();
+                    //return;
+
+                    throw new HttpException(404, "Category not found.");
                 }
 
                 ICollection<Entry> ec = Cacher.GetEntriesByCategory(count, lc.Id, SubtextContext);

src/Subtext.Web/UI/Controls/ViewPost.cs

@@ -17,6 +17,7 @@
 
 using System;
 using System.Globalization;
+using System.Web;
 using System.Web.Mvc;
 using System.Web.UI;
 using System.Web.UI.WebControls;
@@ -40,6 +41,8 @@ public partial class ViewPost : BaseControl
         const string LinkToComments = "<a href=\"{0}#feedback\" title=\"View and Add Comments\">{1}{2}</a>";
         const string LinkToEnclosure = "<a href=\"{0}\" title = \"{1}\">{2}</a>{3}";
 
+        protected Entry Entry { get; private set; }
+
         /// <summary>
         /// Loads the entry specified by the URL.  If the user is an 
         /// admin and the skin supports it, will also display an edit 
@@ -52,81 +55,81 @@ protected override void OnLoad(EventArgs e)
             base.OnLoad(e);
 
             //Get the entry
-            Entry entry = Cacher.GetEntryFromRequest(true, SubtextContext);
+            Entry = Cacher.GetEntryFromRequest(true, SubtextContext);
 
             //if found
-            if (entry != null)
+            if (Entry != null)
             {
-                BindCurrentEntryControls(entry, this);
+                BindCurrentEntryControls(Entry, this);
 
-                DisplayEditLink(entry);
+                DisplayEditLink(Entry);
 
                 var statistics = DependencyResolver.Current.GetService<IStatisticsService>();
-                statistics.RecordWebView(new EntryView { EntryId = entry.Id, BlogId = Blog.Id });
+                statistics.RecordWebView(new EntryView { EntryId = Entry.Id, BlogId = Blog.Id });
 
                 //Set the page title
-                Globals.SetTitle(entry.Title, Context);
+                Globals.SetTitle(Entry.Title, Context);
 
                 //Sent entry properties
-                TitleUrl.Text = entry.Title;
+                TitleUrl.Text = Entry.Title;
                 ControlHelper.SetTitleIfNone(TitleUrl, "Title of this entry.");
-                TitleUrl.NavigateUrl = Url.EntryUrl(entry);
-                Body.Text = entry.Body;
+                TitleUrl.NavigateUrl = Url.EntryUrl(Entry);
+                Body.Text = Entry.Body;
                 if (PostDescription != null)
                 {
                     PostDescription.Text = string.Format(CultureInfo.InvariantCulture, "{0} {1}",
-                                                         entry.DateSyndicated.ToLongDateString(),
-                                                         entry.DateSyndicated.ToShortTimeString());
+                                                         Entry.DateSyndicated.ToLongDateString(),
+                                                         Entry.DateSyndicated.ToShortTimeString());
                 }
                 Trace.Write("loading categories");
                 if (Categories != null)
                 {
-                    Categories.LinkCategories = Repository.GetLinkCategoriesByPostId(entry.Id);
+                    Categories.LinkCategories = Repository.GetLinkCategoriesByPostId(Entry.Id);
                     Categories.DataBind();
                 }
 
                 if (date != null)
                 {
-                    string entryUrl = Url.EntryUrl(entry);
+                    string entryUrl = Url.EntryUrl(Entry);
                     if (date.Attributes["Format"] != null)
                     {
                         date.Text = string.Format(CultureInfo.InvariantCulture, "<a href=\"{0}\" title=\"{2}\">{1}</a>",
-                                                  entryUrl, entry.DateSyndicated.ToString(date.Attributes["Format"]),
+                                                  entryUrl, Entry.DateSyndicated.ToString(date.Attributes["Format"]),
                                                   Resources.EntryList_PermanentLink);
                         date.Attributes.Remove("Format");
                     }
                     else
                     {
                         date.Text = string.Format(CultureInfo.InvariantCulture, "<a href=\"{0}\" title=\"{2}\">{1}</a>",
-                                                  entryUrl, entry.DateSyndicated.ToString("f"),
+                                                  entryUrl, Entry.DateSyndicated.ToString("f"),
                                                   Resources.EntryList_PermanentLink);
                     }
                 }
 
                 if (commentCount != null)
                 {
-                    if (Blog.CommentsEnabled && entry.AllowComments)
+                    if (Blog.CommentsEnabled && Entry.AllowComments)
                     {
-                        string entryUrl = Url.EntryUrl(entry);
-                        if (entry.FeedBackCount == 0)
+                        string entryUrl = Url.EntryUrl(Entry);
+                        if (Entry.FeedBackCount == 0)
                         {
                             commentCount.Text = string.Format(LinkToComments, entryUrl, Resources.EntryList_AddComment,
                                                               string.Empty);
                         }
-                        else if (entry.FeedBackCount == 1)
+                        else if (Entry.FeedBackCount == 1)
                         {
                             commentCount.Text = string.Format(LinkToComments, entryUrl, Resources.EntryList_OneComment,
                                                               string.Empty);
                         }
-                        else if (entry.FeedBackCount > 1)
+                        else if (Entry.FeedBackCount > 1)
                         {
-                            commentCount.Text = string.Format(LinkToComments, entryUrl, entry.FeedBackCount,
+                            commentCount.Text = string.Format(LinkToComments, entryUrl, Entry.FeedBackCount,
                                                               Resources.EntryList_CommentsPlural);
                         }
                     }
                 }
 
-                BindEnclosure(entry);
+                BindEnclosure(Entry);
 
                 //Set Pingback/Trackback 
                 if (PingBack == null)
@@ -136,20 +139,31 @@ protected override void OnLoad(EventArgs e)
 
                 if (PingBack != null)
                 {
-                    PingBack.Text = TrackHelpers.GetPingPackTag(Url);
+                    PingBack.Text = TrackHelpers.GetPingbackTag(Url, Entry);
                 }
 
                 if (TrackBack != null)
                 {
-                    TrackBack.Text = TrackHelpers.TrackBackTag(entry, Blog, Url);
+                    TrackBack.Text = TrackHelpers.TrackBackTag(Entry, Blog, Url);
                 }
                 DataBind();
             }
             else
             {
                 //No post? Deleted? Help :)
-                Controls.Clear();
-                Controls.Add(new LiteralControl(Resources.ViewPost_EntryNotFound));
+                // Attempting to replace the content of this user control with
+                // a static message causes an exception if the skin control
+                // specifies server-side code using "<%= ... %>":
+                //
+                // "System.Web.HttpException: The Controls collection cannot be
+                // modified because the control contains code blocks (i.e. <%
+                // ... %>)."
+                //
+                // To avoid this, mimic a 404 error instead.
+                //
+                //Controls.Clear();
+                //Controls.Add(new LiteralControl(Resources.ViewPost_EntryNotFound));
+                throw new HttpException(404, "Post not found.");
             }
         }
 

src/Subtext.Web/UI/Pages/SubTextMasterPage.cs

@@ -99,13 +99,19 @@ public void InitializeControls(ISkinControlLoader controlLoader)
                     {
                         entryId = entry.Id;
                     }
-                    var query = Query;
-                    if (!String.IsNullOrEmpty(query))
+
+                    // Allow errors in Lucene.Net.QueryParsers.QueryParser to be avoided by
+                    // disabling the full text search engine in Web.config
+                    if (FullTextSearchEngineSettings.Settings.IsEnabled == true)
                     {
-                        var searchResults = SearchEngineService.Search(query, 5, Blog.Id, entryId);
-                        if (searchResults.Any())
+                        var query = Query;
+                        if (!String.IsNullOrEmpty(query))
                         {
-                            AddMoreResultsControl(searchResults, controlLoader, apnlCommentsWrapper);
+                            var searchResults = SearchEngineService.Search(query, 5, Blog.Id, entryId);
+                            if (searchResults.Any())
+                            {
+                                AddMoreResultsControl(searchResults, controlLoader, apnlCommentsWrapper);
+                            }
                         }
                     }
                 }
@@ -220,7 +226,7 @@ public void InitializeBlogPage()
             if (opensearch != null)
             {
                 opensearch.Attributes.Add("href", Url.OpenSearchDescriptorUrl());
-                opensearch.Attributes.Add("Title", Blog.Title);
+                opensearch.Attributes.Add("title", Blog.Title);
             }
 
             if (RSSLink != null)

src/Subtext.Web/Web.config

@@ -18,6 +18,12 @@
     <add name="subtextData" connectionString="Server=.\SQLEXPRESS;Database=SubtextData;Trusted_Connection=True;User Instance=false;" />
   </connectionStrings>
   <FullTextSearchEngineSettings type="Subtext.Framework.Configuration.FullTextSearchEngineSettings, Subtext.Framework">
+    <!-- Change the following to false to prevent related posts from automatically
+      being suggested when users find a post using an Internet search engine
+      (e.g. Google). This will also avoid potential errors in Lucene.Net
+      (e.g. Lucene.Net.QueryParsers.ParseException: Encountered " ":" ": "" at
+      line 1, column ... Was expecting one of: ...). -->
+    <IsEnabled>true</IsEnabled>
     <Parameters>
       <MinimumDocumentFrequency>10</MinimumDocumentFrequency>
     </Parameters>