-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenMM module #482
base: main
Are you sure you want to change the base?
Add OpenMM module #482
Conversation
The code presented in this commit was enterily done by Ivar de Leeuw during his Master course: Major Research Project (GSLS), academic year 2021-2022. I am pushing the code after Ivar's request and in its exact original form. In the next commits, the team will work on Ivar's code to accommodate it fully to the HADDOCK3 project. Thanks Ivar for all your great work and best luck on your future studies!
Made a general linting around files. Addition lint can still be done on function and variable names. |
Hi @joaomcteixeira, just had a quick chat with Ivar De Leeuw about the version of the dependencies he used: it's openmm v. 7.7.0 and pdbfixer 1.8.1. I'll modify the INSTALL.md accordingly |
Okay. I strongly suggest having them defined as optional dependencies, same as lightdock and gdock. |
I totally agree. |
tried a run with the example file
|
I would say this is not ours and is something from |
@mgiulini, the pre-last commit solves the Also corrected some defaults that were lists to single strings |
Undo linting from all previous commits. After linting, some deep bug appeared and I found no way to reproduce the original results. So, we need to lint block by block very carefully. I left the other files: install.md and config_read untouched because those changes will surely go through.
As for the reproducibility: it is possible to assign a seed to the integrators, but not to the modeller functions. Therefore, the solvation boxes specified at the beginning of the simulations are bound to differ. |
Aren’t the solvation boxes built from a pre-equilibrated water box?
|
Hi Alex, the solvation box in openmm is built by default using the TIP3P solvent model, which should be already equilibrated. But the solute-solvent interface mixture is not equilibrated at all, as the water molecules are simply removed in correspondence of the solute. |
That’s standard procedure.
The first equilibration step should be to minimise the solvent with the solute position restrainted, and then heat up the system slowly releasing the solute so that the solvent adapts to the solute (and not vice-versa)
|
Precisely! Following Ivar's code, I didn't include the full procedure in the current implementation to save resources. The system is built, energy-minimized, and then quickly "equilibrated" at the simulation temperature (300 K) for a few steps. Should I include the full equilibration protocol? |
Precisely! Following Ivar's code, I didn't include the full procedure in the current implementation to save resources. The system is built, energy-minimized, and then quickly "equilibrated" at the simulation temperature (300 K) for a few steps. Should I include the full equilibration protocol?
I guess this should be checked at least. In principle starting directly at 300K is fine as long as there are positions restraints on the solute that are slowly removed.
|
I will investigate the code more thoroughly then :) |
Modified linting Commenting the MonteCarloBarostat
Adding comments
resolve #776 |
The code presented in this commit was entirely done by Ivar de Leeuw during his Master course: Major Research Project (GSLS), academic year 2021-2022.
I am pushing the code after Ivar's request and in its exact original form.
In the next commits, the team will work on Ivar's code to accommodate it fully to the HADDOCK3 project.
Thanks, Ivar, for all your great work and best luck with your future studies!