Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysis docs #681

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

analysis docs #681

wants to merge 8 commits into from

Conversation

mgiulini
Copy link
Contributor

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #628 by adding a new .md file in the docs/tutorials folder, namely analysing_runs.md. It describes the basic usage of haddock3-analyse and haddock3-traceback. I also added a couple of example plots for haddock3-analyse

@mgiulini mgiulini self-assigned this Aug 24, 2023
@mgiulini mgiulini marked this pull request as ready for review August 24, 2023 10:00
haddock3-analyse -r my-run-folder -m 2 5 6 -p reference_fname my_ref.pdb receptor_chain F
```

Here the `-p` key tells the code that you are about to insert caprieval parameters, whose name should match the parameter name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter name and corresponding value must be separated by space.

run_dir = "my-run-folder"

# postprocess the run
postprocess = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question (that should be discussed):
shoudn't the value of the postprocess parameter be true by default ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I think we discussed this with @amjjbonvin in the past and decided to set it to false by default, but I am more than open to re-discuss it!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about placing the post-processing section in first ? and then explaining the haddock3-analyse and haddock3-traceback ?

Also adding internal links to the 3 sections that will be later presented ?

Dedicated analyses modules are made available, allowing to investigate the different steps of a HADDOCK3 workflow, even after it has been completed.
* [Post-processing](#the-postprocess-option)  
* [Analyse](#haddock3-analyse)
* [Traceback](#haddock3-traceback)
``` ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree about the bindings but I would not change the order..it's complicated to describe the postprocess option without saying anything about the commands it executes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I would not modify the titles, I think that it's beneficial to have "haddock3-analyse" as a title for the user

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e6cca18) 74.78% compared to head (ba0cb5a) 74.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   74.78%   74.78%           
=======================================
  Files         113      113           
  Lines        7948     7948           
=======================================
  Hits         5944     5944           
  Misses       2004     2004           
Files Changed Coverage Δ
src/haddock/clis/cli_analyse.py 74.39% <ø> (ø)
src/haddock/clis/cli_traceback.py 91.66% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you are proposing is user documentation, but the docs that are built automatically are related to code documentation.

I would not mix these two in the same codebase because user access can be limited by documentation build issues that are unrelated to the information provided in those docs.

User information should fit together with the rest of the material at bonvinlab.org. However this is not for me to decide since I'm not the lead on the project.

@mgiulini
Copy link
Contributor Author

What you are proposing is user documentation, but the docs that are built automatically are related to code documentation.

I would not mix these two in the same codebase because user access can be limited by documentation build issues that are unrelated to the information provided in those docs.

User information should fit together with the rest of the material at bonvinlab.org. However this is not for me to decide since I'm not the lead on the project.

I know this is user documentation, of course. It was thought as a technical guide for people that want to approach the haddock3-specific analysis, as it's done in the other docs/tutorials/ markdown files.
I understand your point about decoupling the repo and the user docs, though I find that having a few technical tutorials within the repo is still useful, especially for developers..I guess we should talk about this with @amjjbonvin at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create detailed documentation for haddock3-analyse
4 participants