-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CNS installation instructions #895
Conversation
ping @VGPReys @AnnaKravchenko |
why is there a \ sign before the cp command ?
Basic Linux, with the \ is uses the basic command, without any option possibly defined in an alias.
|
Also the [bis] statement is quite confusing
Again, Linux shell selection syntax: It will select any file or directory starting with a: b, i or s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job Alex !
Managed to compile CNS on my MAC M2 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, managed to compile CNS all by myself for the first time!
There are several minor suggestions + typos, otherwise it’s perfect.
```bash | ||
ls ~/software/cns_solve_1.3/instlib/machine/supported/*/Makefile*gfortran* | ||
``` | ||
Several `Makefile` headers are already provided - here we will use on the one that uses `gfortran` as the compiler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: on the one -> only the one
Does work on my Mac under tcsh, but not under bash…
And there are some character issues for ‘ and #
… Should we add sed -i '' 's@_CNSsolve_location_@'"$PWD"'@‘ cns_solve_env as an alternative to installing gnu-sed on Mac?
But also idk if it works in general or only ‘on my machine’
|
Yeah, then let’s just keep it as is. After all it’s trivial to make changes manually.
|
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
tox
tests pass. Runtox
command inside the repository folder-test.cfg
examples execute without errors. Insideexamples/
runpython run_tests.py -b
"This PR improves the readablity of the CNS installation instructions and also changes the folder structure of the patched CNS files" @rvhonorato