Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coretext shaper on how to decide fallbacks happen #36

Closed
wants to merge 1 commit into from
Closed

Fix coretext shaper on how to decide fallbacks happen #36

wants to merge 1 commit into from

Commits on May 7, 2014

  1. Fix coretext shaper on how to decide fallbacks happen 

    coretext shaper returns all 0 glyph IDs even for non-fallback fonts.
It's cause it currently compares the CGFont copied from the CTRun
with the CGFont used when creating the original CTFont, a technique
shown in [1]. However, CFEqual() seemed to return false even for
identical fonts getting from single CTRun without any fallback
happening. [2] does show a different method, i.e. comparing the
CTFonts directly instead, which seemed to work for me. (On OS X 10.9)

[1] https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp#L134
[2] https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm#L249
    @jjgod
    jjgod committed May 7, 2014
    Configuration menu
    Copy the full SHA
    9ff0109 View commit details
    Browse the repository at this point in the history