Redact SSH key from URL query parameter #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
|
|
Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
|
Thanks @macedogm! Doesn't look like any HashiCorp tooling calls |
|
@schmichael Thanks a lot for the quick review. 👍🏻 |
|
Hi @schmichael, do you know when a new release will be made with this fix, please? |
|
Done! Unsure when it will make it into downstream tools (Terraform, Nomad, etc) though. |
schmichael
added a commit
to hashicorp/nomad
that referenced
this pull request
Jan 12, 2022
Pulls in hashicorp/go-getter#348 Fixes the possibility to log an sshkey if a specific error condition is hit.
schmichael
added a commit
to hashicorp/nomad
that referenced
this pull request
Jan 12, 2022
Pulls in hashicorp/go-getter#348 Fixes the possibility to log an sshkey if a specific error condition is hit.
|
Mitre assigned CVE-2022-29810 to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes:
xxxxxtoredacted..gitignore.Signed-off-by: Guilherme Macedo guilherme.macedo@suse.com