deps: provider should avoid importing github.com/hashicorp/vault

[jrasell]

Vault issue comment reference: hashicorp/vault#9575 (comment)

The Nomad provider currently imports github.com/hashicorp/vault because of its use of config.DefaultTokenHelper() within provider.go. A per the above discussion Vault imports should be limited to sdk and api otherwise problems may occur.

A quick look indicates there is no token helper functionality within either of the recommended packages, although this was not exhaustive.

[tristanmorgan]

A note for anyone caught when you broke your Vault token helper.... this is the error message displayed.

╷
│ Error: Error getting token helper: unknown error getting the external helper path
│ 
│   with provider["registry.terraform.io/hashicorp/nomad"],
│   on <input-prompt> line 1:
│   (source code not available)
│ 
╵

Is there a reason why a vault misconfiguration should affect a 3 line nomad config?

data "nomad_job" "example" {
  job_id = "example"
}

[lgfa29]

Hi @tristanmorgan,

The Nomad provider uses the same logic as Vault to find a token, so if your Vault token helper is incorrect, the Nomad provider will fail as well.

[lgfa29]

Closed by #445