chore: bump Vault from 0.10.4 to 1.12.1 #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
|
Oh, that's awesome, thanks for noticing that @greut! We've wanted to remove this dependency for a while now 😅 I've rebased and pushed to your branch to fix a conflict after I merged #444. I should've done the other way around but I missed this one. I don't think licensing would be a problem. Both this repo and Thanks for the contribution! |
lgfa29
approved these changes
Mar 18, 2024
I've been hanging onto that PR on Vault for a couple of year :) Thanks for the quick merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to hashicorp/vault#25744, it's now possible to replace Vault with its api sub-package.
Let me know if it goes against the licencing changes.