Fixes #119: Allow overwriting methods in Mash #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a method is overwritten, you can still access it by passing `#hash_<method_name>`. For an example, see the included documentation. This is a breaking change since it changes the behavior of overridden methods, so it should require a version bump for Hashie to adhere to the [Semantic Versioning][semver] policy. [semver]: http://semver.org
|
This is a quick reply, haven't dig into the code, but i don't really get the point of this PR. Could you explain why method access is not enough? thx! :) |
|
Bump @michaelherold |
|
I'll see if I can get to this this week. Got a lot going on at work. Here's what I think needs done from the discussion in the related thread:
Does that sound about right? /cc @gregory since he was a big part of the discussion around this PR |
|
Sounds right to me. |
michaelherold
added a commit
to michaelherold/hashie
that referenced
this pull request
Aug 20, 2014
This is part 1 of 3 of the to-do list determined in hashie#198.
michaelherold
added a commit
to michaelherold/hashie
that referenced
this pull request
Aug 20, 2014
This is part 1 of 3 of the to-do list determined in hashie#198.
michaelherold
added a commit
to michaelherold/hashie
that referenced
this pull request
Aug 20, 2014
This is part 2 of 3 of the to-do list determined in hashie#198.
michaelherold
added a commit
to michaelherold/hashie
that referenced
this pull request
Aug 20, 2014
This is part 2 of 3 of the to-do list determined in hashie#198.
michaelherold
added a commit
to michaelherold/hashie
that referenced
this pull request
Aug 20, 2014
This is part 3 of 3 of the to-do list determined in hashie#198.
michaelherold
added a commit
to michaelherold/hashie
that referenced
this pull request
Aug 20, 2014
This is part 1 of 3 of the to-do list determined in hashie#198.
michaelherold
added a commit
to michaelherold/hashie
that referenced
this pull request
Aug 20, 2014
This is part 2 of 3 of the to-do list determined in hashie#198.
dblock
pushed a commit
that referenced
this pull request
Aug 20, 2014
This is part 2 of 3 of the to-do list determined in #198.
dblock
pushed a commit
that referenced
this pull request
Aug 20, 2014
This is part 3 of 3 of the to-do list determined in #198.
|
Merged all those, great work! What do we want to do with this PR? Close? |
|
Great! 👍 All of the relevant stuff is split up between those other PRs, so I'm going to go ahead and close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Mash
When a method is overwritten, you can still access it by passing
#hash_<method_name>. For an example, see the included documentation.This is a breaking change since it changes the behavior of overridden methods, so it should require a version bump for Hashie to adhere to the Semantic Versioning policy.
Smash
Added as a safe alternative to Mash. A Smash prevents the user from overwriting a method with an attribute. This is more along the lines of the original Mash, except that it raises an
ArgumentErrorif the user tries to overwrite a method with an attribute.