bug fix of twittering-status-not-blank-p

* twittering-mode.el (twittering-status-not-blank-p): bug fix:
always return nil with strings with trailing newline.

ChangeLog

@@ -3,6 +3,11 @@
 	* twittering-mode.el (twittering-use-show-minibuffer-length): Add
 	suggestion into a docstring.
 
+2010-01-08  Yuto Hayamizu  <y.hayamizu@gmail.com>
+
+	* twittering-mode.el (twittering-status-not-blank-p): bug fix:
+	always return nil with strings with trailing newline.
+
 2010-01-07  Yuto Hayamizu  <y.hayamizu@gmail.com>
 
 	* twittering-mode.el (twittering-url-reserved-p): bug fix: some

test/test-twittering-mode.el

@@ -350,3 +350,15 @@
   (test-assert-ok (not (twittering-url-reserved-p ?\\)))
   (test-assert-ok (not (twittering-url-reserved-p ?^)))
   (test-assert-ok (not (twittering-url-reserved-p ?`))))
+
+(defcase test-status-not-blank-p nil nil
+  (test-assert-ok (not (twittering-status-not-blank-p "")))
+  (test-assert-ok (not (twittering-status-not-blank-p "\n")))
+  (test-assert-ok (not (twittering-status-not-blank-p "@foo")))
+  (test-assert-ok (not (twittering-status-not-blank-p "@bar ")))
+  (test-assert-ok (twittering-status-not-blank-p "hello"))
+  (test-assert-ok (twittering-status-not-blank-p "@baz hello"))
+  (test-assert-ok (twittering-status-not-blank-p "@baz\n\nhello"))
+  (test-assert-ok (twittering-status-not-blank-p "\nhello"))
+  (test-assert-ok (twittering-status-not-blank-p "hello\n"))
+  )

twittering-mode.el

@@ -1819,9 +1819,13 @@ following symbols;
   (remove-hook 'post-command-hook 'twittering-show-minibuffer-length t))
 
 (defun twittering-status-not-blank-p (status)
-  (not (string-match
-	"^\\s-*\\(?:@[-_a-z0-9]+\\(?:\\s-+@[-_a-z0-9]+\\)*\\)?\\s-*$" status)))
-
+  (with-temp-buffer
+    (insert status)
+    (goto-char (point-min))
+    (while (re-search-forward "@[-_a-z0-9]+" nil t)
+      nil) ;; skip user name
+    (re-search-forward "[^\n\r \t]+" nil t)))
+
 (defun twittering-update-status-from-minibuffer (&optional init-str reply-to-id)
   (when (and (null init-str)
 	     twittering-current-hashtag)