Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to setup.cfg and use pyHDLParser fork as dependency #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kammoh
Copy link

@kammoh kammoh commented Mar 8, 2022

Hi,
As far as I could see, your pyHDLParser has not yet been published on PyPi.
This PR:

  • Switches to using the modern setup.cfg (setup.py is set to be eventually deprecated)
  • VHDL: there's no reason a 'component' definition should exist, especially in the file containing the actual implementation (entity/architecture). Suggested Fix: use both components (increase backwards compatibility) and entities.
  • Use https://github.com/hdl/pyHDLParser.git for the pyhdl dependency
  • Bump version to 1.1.0 to avoid version collisions
  • cleanup and format symbolator.py (as a first step)

Hope it's going to be useful. Please let me know if you'd like any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant