Pin country_select version in README

[DanielPechersky]

The latest release of Simple Form breaks with country_select 9.0.0

[carlosantoniodasilva]

Can you show what the error or incompatibility is? I'd rather try to fix that, find a way to work with all versions, if we can, but first I need to understand more. Thanks!

[DanielPechersky]

I'll get you more information on the error, but you should pin the version of country_select anyways. Otherwise the user's code will break in this circumstance:

1. A user copy pastes gem 'country_select' from your README
2. country_select publishes a new major version
3. The user updates all their gems, and country_select is no longer compatible with Simple Form

[carlosantoniodasilva]

I appreciate the feedback. How users decide to define the gem on their gemfiles is probably not a big concern we should have though, some prefer to pin, others prefer to leave it open, in any case bundle updating multiple gems is generally not advised.

There's also the concern of it becoming an extra small burden to be updating the readme every time with new country_select versions ourselves. Plus, we wouldn't get these helpful reports when it breaks. :)

[DanielPechersky]

This seems to be the relevant information:

#<ArgumentError: wrong number of arguments (given 4, expected 1..3)>

/Users/dannyp/.rbenv/versions/3.2.2/gemsets/foo/gems/country_select-9.0.0/lib/country_select/country_select_helper.rb:6:in `country_select'
/Users/dannyp/.rbenv/versions/3.2.2/gemsets/foo/gems/formtastic-5.0.0/lib/formtastic/inputs/country_input.rb:77:in `block in to_html'

[carlosantoniodasilva]

I ran the tests with a full bundle update here, which used country_select v9.0.0, and didn't run into any errors other than the fact that they dropped support to Ruby 2.7 already apparently (as did some other gems).

[carlosantoniodasilva]

@DanielPechersky it looks like you're using formtastic instead, which has a PR to add support to country_select v9.0.0.

Let me know if you run into anything with SimpleForm.

[DanielPechersky]

Ah, looks like this is the fabled "user error". Apologies

[carlosantoniodasilva]

No worries, glad I could help. 👍