Improved form rendering #11

madsmtm · 2018-09-10T08:48:02Z

Updated form rendering to properly use bootstrap v.4, it now also works with nested forms and custom form elements.
Basically, I just went to bootstrap/components/forms, and implemented the rendering based on the examples there.
I've made the interface a lot more flexible, but and if if you think its needed yet, I can make it backwards compatible

If you approve, I'll attempt to make some documentation

madsmtm · 2018-09-10T08:51:34Z

Since you can't easily override macros, I've wrapped them all in a block that you can then extend, the alternative would be this. There's also a block that you can extend if you need to provide rendering of custom form elements

…tchaWidget`

coveralls · 2018-09-10T09:24:15Z

Pull Request Test Coverage Report for Build 37

3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.7%) to 86.538%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
flask_bootstrap/init.py	3	4	75.0%

Files with Coverage Reduction	New Missed Lines	%
flask_bootstrap/init.py	1	86.54%

Totals
Change from base Build 28:	-1.7%
Covered Lines:	45
Relevant Lines:	52

💛 - Coveralls

madsmtm · 2018-09-10T12:03:49Z

I'm still not really satisfied with how widgets, especially TableWidgets, are rendered inside ListWidgets, I'd like the label & help text to be in a top row if possible

greyli · 2018-09-12T13:52:35Z

Thanks very much! I will review your code as soon as I have free time.

madsmtm · 2018-09-12T15:01:11Z

flask_bootstrap/templates/bootstrap/form.html

+{%- macro hidden_errors(field) -%}
+{%- block hidden_errors scoped -%}
+    {# Doesn't actually work, has no element which makes it "display: block" #}


Also regarding this, do you know how the preffered way of displaying errors like this is in bootstrap? We can't use the normal <span class="invalid-feedback">, since that's specific to form elements. Something like <div class="flash alert alert-danger"> perhaps?

Use Alert will be good. Why adding a flash class?

I'm not really sure why I thought that, I probably just looked at some legacy code ;)

greyli · 2018-09-17T11:01:31Z

setup.py

@@ -32,8 +32,11 @@
    include_package_data=True,
    test_suite='test_bootstrap_flask',
    install_requires=[
-        'Flask'
+        'Flask>=1'


Why need Flask >= 1?

Because Flask versions below v1.0.0 require Jinja2>=2.4, while we need at least Jinja2>=2.8 (Or around there). Maybe it would be better to add an explicit requirement?

All right...

greyli · 2018-09-17T11:04:21Z

LGTM! Just go ahead to update the docs.

greyli · 2018-09-17T11:07:27Z

I've made the interface a lot more flexible, but and if you think its needed yet, I can make it backward compatible.

Does this PR break something?

madsmtm · 2018-09-17T11:12:54Z

Does this PR break something?

I've changed the interface of the render_field, render_form macros and removed the form_errors macro. I've also removed the bootstrap_is_hidden_field jinja function, and replaced it with the is_hidden test

greyli · 2018-09-17T12:04:36Z

IMO, it's a good idea to make it backward compatible.

madsmtm · 2018-09-17T14:16:30Z

I've tried documenting a little bit, but I'm unsure about the format. Should I:

Make a seperate file, where I put information about all the methods, and how to customize the form rendering
Only document the single render_form method

Or something in between those two?

greyli · 2018-09-17T14:25:59Z

I prefer to make a new file.

greyli · 2018-09-17T14:29:59Z

docs/macros.rst

@@ -120,51 +84,20 @@ Example
 API
 ~~~~

-.. py:function:: quick_form(form,\
-                    action="",\
-                    method="post",\


Why these arguments were removed?

I made them be part of kwargs instead

greyli · 2018-09-17T14:35:13Z

Can we just keep the old keyword arguments (i.e. action, method, extra_classes etc)? Both in the code and the docs. These arguments were commonly used when people rendering a form.

madsmtm · 2018-09-17T14:40:15Z

If you feel like we should do that, then yes, easily. Which ones do you want to keep precisely, action, method, role, enctype, id, novalidate and extra_classes?

greyli · 2018-09-17T14:51:03Z

@madsmtm We need to let user transfer easily from Flask—Bootstrap to this project, so I want to keep all of them.

madsmtm · 2018-09-17T16:50:19Z

Well, but I don't see a reason to update the code, since after I made it backwards compatible, they can, they don't need to do anything. But if you want it added to the docs, I'll be happy to do so, I'm out of time for today though

examples/templates/form.html

greyli · 2018-09-18T00:13:45Z

OK, you are right, just update the docs will be enough.

madsmtm added 2 commits September 7, 2018 12:02

Improved form rendering

8b07a40

Added support for horizontal forms + more

4a2d4d8

Fixed failing test, and added (official) support for `flask_wtf/Recap…

7ea5caa

…tchaWidget`

madsmtm commented Sep 12, 2018

View reviewed changes

greyli reviewed Sep 17, 2018

View reviewed changes

Fixed hidden_errors macro

bb7dd60

madsmtm added 4 commits September 17, 2018 15:39

Updated for backwards compatibility, added Jinja>=2.8 as requirement

a3caa8a

Fixed copying mistake, and changed required jinja version to 2.10

eaaaec5

Updated example app to use new form features

d231989

Initial work on documenting form.html

7c6c99d

Fixed setup.py, added missing commas

6e2070b

greyli reviewed Sep 17, 2018

View reviewed changes

greyli reviewed Sep 18, 2018

View reviewed changes

examples/templates/form.html Show resolved Hide resolved

greyli added enhancement New feature or request in process labels Nov 14, 2018

greyli added this to the 1.1 milestone Mar 13, 2019

greyli modified the milestones: 1.1, 2.0.0 Jun 13, 2021

greyli modified the milestones: 2.0.0, 3.0 Jan 12, 2022

PanderMusubi added the form label Apr 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved form rendering #11

Improved form rendering #11

madsmtm commented Sep 10, 2018

madsmtm commented Sep 10, 2018

coveralls commented Sep 10, 2018 •

edited

madsmtm commented Sep 10, 2018

greyli commented Sep 12, 2018

madsmtm Sep 12, 2018

greyli Sep 17, 2018

madsmtm Sep 17, 2018

greyli Sep 17, 2018

madsmtm Sep 17, 2018

greyli Sep 17, 2018

greyli commented Sep 17, 2018

greyli commented Sep 17, 2018

madsmtm commented Sep 17, 2018 •

edited

greyli commented Sep 17, 2018

madsmtm commented Sep 17, 2018

greyli commented Sep 17, 2018

greyli Sep 17, 2018

madsmtm Sep 17, 2018

greyli commented Sep 17, 2018 •

edited

madsmtm commented Sep 17, 2018

greyli commented Sep 17, 2018

madsmtm commented Sep 17, 2018

greyli commented Sep 18, 2018

Improved form rendering #11

Are you sure you want to change the base?

Improved form rendering #11

Conversation

madsmtm commented Sep 10, 2018

madsmtm commented Sep 10, 2018

coveralls commented Sep 10, 2018 • edited

Pull Request Test Coverage Report for Build 37

💛 - Coveralls

madsmtm commented Sep 10, 2018

greyli commented Sep 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greyli commented Sep 17, 2018

greyli commented Sep 17, 2018

madsmtm commented Sep 17, 2018 • edited

greyli commented Sep 17, 2018

madsmtm commented Sep 17, 2018

greyli commented Sep 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greyli commented Sep 17, 2018 • edited

madsmtm commented Sep 17, 2018

greyli commented Sep 17, 2018

madsmtm commented Sep 17, 2018

greyli commented Sep 18, 2018

coveralls commented Sep 10, 2018 •

edited

madsmtm commented Sep 17, 2018 •

edited

greyli commented Sep 17, 2018 •

edited