Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty reply error #365

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kladaFOX
Copy link

@kladaFOX kladaFOX commented Feb 2, 2023

For developers to understand the problem.
Without this handling we are receiving this:

19:20:17 sidekiq.1 | undefined method `collect' for nil:NilClass
19:20:17 sidekiq.1 | 
19:20:17 sidekiq.1 |         unstructured_replies.collect do |reply|
19:20:17 sidekiq.1 |                             ^^^^^^^^
19:20:17 sidekiq.1 | /Users/ilyaklapatok/RubymineProjects/stealth/lib/stealth/service_reply.rb:31:in `load_replies'

@mgomes
Copy link
Member

mgomes commented Feb 7, 2023

Thanks for the contribution @kladaFOX! Could you take a look at the failing spec?

@kladaFOX
Copy link
Author

kladaFOX commented Feb 7, 2023

Thanks for the contribution @kladaFOX! Could you take a look at the failing spec?

Can you recheck it?

@kladaFOX
Copy link
Author

@mgomes

@matthewblack
Copy link
Member

Man... The amount of times this has happened to me. 🤪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants