Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/centrifugo] deprecating chart #24289

Merged
merged 1 commit into from
Nov 13, 2020
Merged

[stable/centrifugo] deprecating chart #24289

merged 1 commit into from
Nov 13, 2020

Conversation

mattfarina
Copy link
Contributor

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@mattfarina
[stable/centrifugo] deprecating chart
2f4e364 
Signed-off-by: Matt Farina <matt@mattfarina.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

@mattfarina: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-charts-e2e 2f4e364 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

unguiculus
unguiculus approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@unguiculus unguiculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging manually. Chart is being deprecated and no longer builds.

@cpanato cpanato merged commit 05063f0 into helm:master Nov 13, 2020
unguiculus
unguiculus approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@unguiculus unguiculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging manually. Chart is being deprecated and no longer builds.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattfarina, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mattfarina,unguiculus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scottrigby
Copy link
Member

#24310

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unguiculus unguiculus unguiculus approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@prydonius prydonius Awaiting requested review from prydonius

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mattfarina @k8s-ci-robot @scottrigby @unguiculus @cpanato @helm-bot