Hotfixes #5

henriiquecampos · 2018-03-05T14:07:24Z

#1 seems to be fixed with this:

		if note == null:
			return
		var pitch = key
		var duration = note.duration
		note.finished()
		note = null

Also added the same "nullifier" to the var object. Hopefully this will do the job

Also fixed a weird behavior when playing a note and then moving, now the character only moves if is not playing and vice versa. This also adds another layer of control for basic_character.gd since now if the character can't move, nothing of the physics_process will happen

When changing to next scene the finished/skip/next button is disabled. Also added a disabled style box to the theme, so when the button is disabled it doesn't seem weird looking.

The major problem of #1 is that after the first time the references are set, they won't reset to null, so the check would only happens successfully once. Now this may definitely fix #1 Also cleared the code removing "can_interact" logic, it isn't needed with the new approach

henriiquecampos added 3 commits March 5, 2018 10:12

Fixed #1

ebce780

Also fixed a weird behavior when playing a note and then moving, now the character only moves if is not playing and vice versa. This also adds another layer of control for basic_character.gd since now if the character can't move, nothing of the physics_process will happen

Fixed #2

13cd2d1

When changing to next scene the finished/skip/next button is disabled. Also added a disabled style box to the theme, so when the button is disabled it doesn't seem weird looking.

henriiquecampos added the engineering An engineering solution to implement a design label Mar 5, 2018

Merge branch 'master' into hotfixes

2c2d508

henriiquecampos merged commit f5739d4 into master Mar 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hotfixes #5

Hotfixes #5

henriiquecampos commented Mar 5, 2018

Hotfixes #5

Hotfixes #5

Conversation

henriiquecampos commented Mar 5, 2018