Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate pg:info to cli/core #2820

Merged
merged 8 commits into from May 1, 2024

Conversation

k80bowman
Copy link
Contributor

Work item

Notes

  • Please take a close look at the logic, especially the displayDB function. I had to do a bit of refactoring on that one because of Typescript requirements.

Testing

  • Check out this branch and run yarn and yarn build
  • Find or set up an app with a postgres database
  • Run ./bin/run pg:info --help and verify that you get the expected result
  • Run ./bin/run pg:info -a APP_NAME DATABASE_NAME. Verify that you get the expected result.

Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment for an optional consideration but otherwise, LGTM!

@k80bowman k80bowman merged commit 90caefe into prerelease/9.0.0-alpha May 1, 2024
8 checks passed
@k80bowman k80bowman deleted the k80/pg-v5/pg-info branch May 1, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants