New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate pg:info to cli/core #2820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k80bowman
temporarily deployed
to
AcceptanceTests
April 18, 2024 15:16
— with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
April 18, 2024 15:16
— with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
April 18, 2024 15:16
— with
GitHub Actions
Inactive
justinwilaby
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment for an optional consideration but otherwise, LGTM!
k80bowman
force-pushed
the
k80/pg-v5/pg-info
branch
from
April 30, 2024 16:11
d4bc892
to
e40b822
Compare
k80bowman
had a problem deploying
to
AcceptanceTests
April 30, 2024 16:12
— with
GitHub Actions
Failure
k80bowman
had a problem deploying
to
AcceptanceTests
April 30, 2024 16:12
— with
GitHub Actions
Failure
k80bowman
had a problem deploying
to
AcceptanceTests
April 30, 2024 16:12
— with
GitHub Actions
Failure
k80bowman
temporarily deployed
to
AcceptanceTests
April 30, 2024 17:50
— with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
April 30, 2024 17:50
— with
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
April 30, 2024 17:50
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item
Notes
Testing
yarn
andyarn build
./bin/run pg:info --help
and verify that you get the expected result./bin/run pg:info -a APP_NAME DATABASE_NAME
. Verify that you get the expected result.