Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(container-registry-v5): Error out container:push command if stack is not container #2844

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

fix(container-registry-v5): Error out container:push command if stack is not container #2844

wants to merge 18 commits into from
+785 −688

Conversation

benri
Copy link

@benri benri commented Apr 26, 2024

Restrict container:* CLI commands to apps with stack=container

GUS-W-15427582

@benri benri marked this pull request as ready for review April 26, 2024 19:38
@benri benri requested a review from a team as a code owner April 26, 2024 19:38
epchris
epchris reviewed Apr 26, 2024
View reviewed changes
Copy link

@epchris epchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @benri 👍 I really like the approach of the assertExit function. I left a couple of comments about naming that would have helped me understand better and would love your thoughts.

packages/container-registry-v5/lib/helpers.js Outdated Show resolved Hide resolved
packages/container-registry-v5/test/testutil.js Outdated Show resolved Hide resolved
@benri benri enabled auto-merge (squash) April 29, 2024 18:13
@benri benri disabled auto-merge April 29, 2024 18:44
@benri benri temporarily deployed to AcceptanceTests May 2, 2024 18:51 — with GitHub Actions Inactive
@benri benri temporarily deployed to AcceptanceTests May 2, 2024 18:51 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epchris epchris epchris left review comments

@jabrown85 jabrown85 jabrown85 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benri @epchris @jabrown85