Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(spaces): Move command spaces:hosts to oclif #2845

Merged
merged 5 commits into from May 3, 2024
Merged

refactor(spaces): Move command spaces:hosts to oclif #2845

merged 5 commits into from May 3, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Apr 26, 2024

Description

GUS item

This converts spaces:hosts to oclif and its associated tests.

Testing

  1. Pull down this branch and run yarn build
  2. Run ./bin/run spaces:hosts SPACE_NAME against an existing space
  3. Compare with prod

@eablack eablack self-assigned this Apr 26, 2024
@eablack eablack marked this pull request as ready for review April 26, 2024 18:38
@eablack eablack requested a review from a team as a code owner April 26, 2024 18:38
@sbosio sbosio self-requested a review April 29, 2024 13:56
sbosio
sbosio requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command is returning API errors. I believe the issue is a missing header to ask for a specific schema variant, but didn't dug too much into it.

packages/cli/src/commands/spaces/hosts.ts Outdated Show resolved Hide resolved
@eablack eablack force-pushed the eb/convert-spaces-hosts-to-oclif branch from ba5376b to 7d66d90 Compare April 30, 2024 16:09
@eablack eablack requested a review from sbosio April 30, 2024 16:56
@eablack eablack force-pushed the eb/convert-spaces-hosts-to-oclif branch from 00f747c to 9232b99 Compare May 2, 2024 19:06
@eablack eablack temporarily deployed to AcceptanceTests May 2, 2024 19:06 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests May 2, 2024 19:06 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests May 2, 2024 19:06 — with GitHub Actions Inactive
sbosio
sbosio approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected now. Great job!

eablack and others added 2 commits May 3, 2024 10:07
@eablack @sbosio
Update packages/cli/src/commands/spaces/hosts.ts
2af7abb 
Co-authored-by: Santiago Bosio <santiago.bosio@gmail.com>
@eablack
Add variant to hosts command
dfbf28b
@eablack eablack force-pushed the eb/convert-spaces-hosts-to-oclif branch from 9232b99 to dfbf28b Compare May 3, 2024 17:07
@eablack eablack temporarily deployed to AcceptanceTests May 3, 2024 17:07 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests May 3, 2024 17:07 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests May 3, 2024 17:07 — with GitHub Actions Inactive
@eablack eablack merged commit 7eeb63c into prerelease/9.0.0-alpha May 3, 2024
8 checks passed
@eablack eablack deleted the eb/convert-spaces-hosts-to-oclif branch May 3, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbosio sbosio sbosio approved these changes

Assignees

@eablack eablack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eablack @sbosio